From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp-vbr1.xs4all.nl ([194.109.24.21]:2773 "EHLO smtp-vbr1.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753044AbaIHIID (ORCPT ); Mon, 8 Sep 2014 04:08:03 -0400 Message-ID: <540D63D1.2010402@xs4all.nl> Date: Mon, 08 Sep 2014 10:07:45 +0200 From: Hans Verkuil MIME-Version: 1.0 To: Sudip Mukherjee , Mauro Carvalho Chehab CC: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Davis Subject: Re: [PATCH] drivers: media: radio: radio-miropcm20.c: include missing header file References: <1409299681-28409-1-git-send-email-sudipm.mukherjee@gmail.com> <20140906112453.GA9405@sudip-PC> In-Reply-To: <20140906112453.GA9405@sudip-PC> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 09/06/2014 01:24 PM, Sudip Mukherjee wrote: > On Fri, Aug 29, 2014 at 01:38:01PM +0530, Sudip Mukherjee wrote: >> with -Werror=implicit-function-declaration build failed with error : >> error: implicit declaration of function 'inb' >> error: implicit declaration of function 'outb' >> >> Reported-by: Jim Davis >> Signed-off-by: Sudip Mukherjee >> --- >> >> Jim reported for next-20140828 , but the error still persists in next-20140829 also. >> >> >> drivers/media/radio/radio-miropcm20.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/media/radio/radio-miropcm20.c b/drivers/media/radio/radio-miropcm20.c >> index 998919e..3309f7c 100644 >> --- a/drivers/media/radio/radio-miropcm20.c >> +++ b/drivers/media/radio/radio-miropcm20.c >> @@ -36,6 +36,7 @@ >> #include >> #include >> #include >> +#include >> >> #define RDS_DATASHIFT 2 /* Bit 2 */ >> #define RDS_DATAMASK (1 << RDS_DATASHIFT) >> -- >> 1.8.1.2 >> > > gentle ping. > build fails on next-20140905 also with the attached config (-Werror=implicit-function-declaration) I hadn't forgotten this. However, I will be taking the same patch from Randy Dunlap instead of yours since his commit log was formatted better, so less work for me :-) Regards, Hans > > thanks > sudip >