From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQwZB-0004cn-VR for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:53:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQwZ5-00081T-U1 for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:53:01 -0400 Message-ID: <540D8A87.2090706@suse.de> Date: Mon, 08 Sep 2014 12:52:55 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1409851240-48126-1-git-send-email-agraf@suse.de> <859F3497-872B-4EEC-BC9E-93E391A97F70@suse.de> <5408C355.90401@gmail.com> <5408E4E8.9030708@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-ppc] [PULL 00/52] ppc patch queue 2014-09-04 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Tom Musta , "qemu-ppc@nongnu.org" , QEMU Developers On 05.09.14 12:36, Peter Maydell wrote: > On 4 September 2014 23:17, Alexander Graf wrote: >> Peter, please pull the same tag name again - I updated it with the now >> working state. > > Doesn't build on Windows: > > hw/ppc/spapr.o: In function `spapr_populate_memory': > /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:708: undefined > reference to `_ffsl' > /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:708: undefined > reference to `_ffsl' > /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:709: undefined > reference to `_ffsl' > > Don't try to use ffs() or ffsl() -- use the ctz32(), > ctz64() or ctzl() functions in host-utils.h (whichever > is appropriate for the size of the type; in this > case ctz64 I think). Watch out that in the common > case ctzl(x) == ffsl(x) - 1, and check the handling > of the edge case of zero input is what you want. I've squashed Alexey's fix into the offending commit and rewrote the tag. Hopefully everything works out this time. Alex