From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40034)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1XQwdd-00040l-Rl
	for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:57:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1XQwdX-0000wp-Vs
	for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:57:37 -0400
Received: from isrv.corpit.ru ([86.62.121.231]:38614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1XQwdX-0000vS-MU
	for qemu-devel@nongnu.org; Mon, 08 Sep 2014 06:57:31 -0400
Message-ID: <540D8B91.1060805@msgid.tls.msk.ru>
Date: Mon, 08 Sep 2014 14:57:21 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1407747189-7936-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1407747189-7936-11-git-send-email-zhang.zhanghailiang@huawei.com>
	<20140908083754.GC7638@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140908083754.GC7638@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 10/10] block/vvfat: fix setbuf stream
 parameter may be NULL
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: kwolf@redhat.com, lkurusa@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, riku.voipio@iki.fi, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, stefanha@redhat.com, Li Liu <john.liuli@huawei.com>, pbonzini@redhat.com, lcapitulino@redhat.com, alex.bennee@linaro.org, rth@twiddle.net

08.09.2014 12:37, Stefan Hajnoczi wrote:
> On Mon, Aug 11, 2014 at 04:53:09PM +0800, zhanghailiang wrote:
>> From: Li Liu <john.liuli@huawei.com>
>>
>> fopen() may return NULL which will cause setbuf() segmentfault
[]
> This no longer exists:
> 
> commit 13b552c2f43298a42e26d7aec7b58a5c205b75a0
> Author: Michael Tokarev <mjt@tls.msk.ru>
> Date:   Wed Aug 20 19:02:38 2014 +0400
> 
>     block/vvfat.c: remove debugging code to reinit stderr if NULL

The second patch is a result of discussion emerged after first patch,
consider the commit to be a follow-up for the initial patch :)

Thanks,

/mjt