All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
	David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] net: fix skb_page_frag_refill() kerneldoc
Date: Mon, 08 Sep 2014 15:04:28 +0400	[thread overview]
Message-ID: <540D8D3C.9080202@cogentembedded.com> (raw)
In-Reply-To: <1410174000.11872.94.camel@edumazet-glaptop2.roam.corp.google.com>

Hello.

On 9/8/2014 3:00 PM, Eric Dumazet wrote:

> From: Eric Dumazet <edumazet@google.com>

> In commit d9b2938aabf7 ("net: attempt a single high order allocation)
> I forgot to update kerneldoc, as @prio parameter was renamed to @gfp

> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>   net/core/sock.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/net/core/sock.c b/net/core/sock.c
> index d372b4bd3f99..9c3f823e76a9 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -1866,7 +1866,7 @@ EXPORT_SYMBOL(sock_alloc_send_skb);
>    * skb_page_frag_refill - check that a page_frag contains enough room
>    * @sz: minimum size of the fragment we want to get
>    * @pfrag: pointer to page_frag
> - * @prio: priority for memory allocation
> + * @gfp: priority for memory allocation

    'gfp' is not priority, it's just flags.

WBR, Sergei

  reply	other threads:[~2014-09-08 11:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 11:00 [PATCH net] net: fix skb_page_frag_refill() kerneldoc Eric Dumazet
2014-09-08 11:04 ` Sergei Shtylyov [this message]
2014-09-08 11:22   ` Eric Dumazet
2014-09-08 21:13   ` David Miller
2014-09-08 21:12 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540D8D3C.9080202@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.