From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Wen Congyang <wency@cn.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Dong Eddie <eddie.dong@intel.com>,
xen devel <xen-devel@lists.xen.org>,
Hong Tao <bobby.hong@huawei.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: [RFC Patch v3 01/18] copy the correct page to memory
Date: Mon, 8 Sep 2014 12:58:02 +0100 [thread overview]
Message-ID: <540D99CA.1000704@citrix.com> (raw)
In-Reply-To: <1410175661.10156.191.camel@kazak.uk.xensource.com>
On 08/09/14 12:27, Ian Campbell wrote:
> On Fri, 2014-09-05 at 17:10 +0800, Wen Congyang wrote:
>> From: Hong Tao <bobby.hong@huawei.com>
>>
>> apply_batch() only handles MAX_BATCH_SIZE pages at one time. If
>> there is some bogus/unmapped/allocate-only/broken page, we will
>> skip it. So when we call apply_batch() again, the first page's
>> index is curbatch - invalid_pages. invalid_pages stores the number
>> of bogus/unmapped/allocate-only/broken pages we have found.
>>
>> In many cases, invalid_pages is 0, so we don't catch this error.
>>
>> Signed-off-by: Hong Tao <bobby.hong@huawei.com>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Hopefully all of this stuff will soon be replaced by migration v2 but we
> may as well apply this fix in the meantime. CCing Andy C on the unlikely
> chance that he carried this misbehaviour over into v2.
I rewrote all of this from scratch.
Amongst other things, the v2 code doesn't batch explicitly batch on the
restoring side. It will deal with an individual PAGE_DATA record at
once, which will generally contain 1024 pages of data, but will not
cache some parts of this to batch better with the following PAGE_DATA
record, which appears to be the source of this bug.
As for deletion. I am planning to delete it as part of the v2 series,
although that might get complicated if remusv2 is not ready by that point.
~Andrew
next prev parent reply other threads:[~2014-09-08 11:58 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 9:10 [RFC Patch v3 00/18] Some bugfix patches Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 01/18] copy the correct page to memory Wen Congyang
2014-09-08 11:27 ` Ian Campbell
2014-09-08 11:58 ` Andrew Cooper [this message]
2014-09-05 9:10 ` [RFC Patch v3 02/18] csum the correct page Wen Congyang
2014-09-08 11:28 ` Ian Campbell
2014-09-05 9:10 ` [RFC Patch v3 03/18] don't zero out ioreq page Wen Congyang
2014-09-05 9:25 ` Paul Durrant
2014-09-05 9:33 ` Wen Congyang
2014-09-05 9:39 ` Paul Durrant
2014-09-05 10:45 ` David Vrabel
2014-09-12 7:33 ` Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 04/18] blktap2: dynamic allocate aio_requests to avoid -EBUSY error Wen Congyang
2014-09-08 11:34 ` Ian Campbell
2014-09-24 18:22 ` Shriram Rajagopalan
2014-09-05 9:10 ` [RFC Patch v3 05/18] blktap2: return the correct dev path Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 06/18] blktap2: use correct way to get free event id Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 07/18] blktap2: don't return negative " Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 08/18] blktap2: use correct way to define array Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 09/18] block-remus: fix memory leak Wen Congyang
2014-09-24 19:37 ` Shriram Rajagopalan
2014-09-25 5:23 ` Wen Congyang
2014-09-25 11:14 ` Shriram Rajagopalan
2014-09-26 2:29 ` Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 10/18] block-remus: pass uuid to the callback td_open Wen Congyang
2014-09-24 19:27 ` Shriram Rajagopalan
2014-09-05 9:10 ` [RFC Patch v3 11/18] block-remus: use correct way to get remus_image Wen Congyang
2014-09-24 19:26 ` Shriram Rajagopalan
2014-09-05 9:10 ` [RFC Patch v3 12/18] block-remus: fix bug in tdremus_close() Wen Congyang
2014-09-24 19:24 ` Shriram Rajagopalan
2014-09-05 9:10 ` [RFC Patch v3 13/18] don't call client_flush() when switching to unprotected mode Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 14/18] pass correct file to qemu if we use blktap2 Wen Congyang
2014-09-08 11:35 ` Ian Campbell
2014-09-05 9:10 ` [RFC Patch v3 15/18] support blktap remus in xl Wen Congyang
2014-09-08 11:39 ` Ian Campbell
2014-09-10 7:19 ` Wen Congyang
2014-09-10 10:04 ` Ian Campbell
2014-09-10 10:36 ` Wen Congyang
2014-09-05 9:10 ` [RFC Patch v3 16/18] update libxl__device_disk_from_xs_be() to support blktap device Wen Congyang
2014-09-08 11:42 ` Ian Campbell
2014-09-09 1:57 ` Wen Congyang
2014-09-11 7:58 ` Wen Congyang
2014-09-12 8:53 ` Wei Liu
2014-09-12 9:03 ` Wen Congyang
2014-09-12 10:35 ` Wei Liu
2014-09-05 9:11 ` [RFC Patch v3 17/18] read nictype from xenstore Wen Congyang
2014-09-08 11:41 ` Ian Campbell
2014-09-05 9:11 ` [RFC Patch v3 18/18] x86/hvm: Always set pending event injection when loading VMC[BS] state Wen Congyang
2014-09-10 15:06 ` Aravind Gopalakrishnan
2014-09-11 6:10 ` Wen Congyang
2014-09-11 10:35 ` Tim Deegan
2014-09-12 3:14 ` Wen Congyang
2014-09-12 15:43 ` Tim Deegan
2014-09-17 7:56 ` Wen Congyang
2014-09-17 14:29 ` Aravind Gopalakrishnan
2014-09-18 0:05 ` Aravind Gopalakrishnan
2014-09-18 0:05 ` Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540D99CA.1000704@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=bobby.hong@huawei.com \
--cc=eddie.dong@intel.com \
--cc=laijs@cn.fujitsu.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=yanghy@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.