From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier MATZ Subject: Re: [PATCH 08/13] mbuf: add named points inside the mbuf structure Date: Mon, 08 Sep 2014 14:08:55 +0200 Message-ID: <540D9C57.4070206@6wind.com> References: <1409759378-10113-1-git-send-email-bruce.richardson@intel.com> <1409759378-10113-9-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Bruce Richardson , dev-VfR2kkLFssw@public.gmane.org Return-path: In-Reply-To: <1409759378-10113-9-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 09/03/2014 05:49 PM, Bruce Richardson wrote: > Add markers or "labels" at given points inside the mbuf which can be > used instead of individual fields to identify the start of logical > sections inside the mbuf. > > The use of typedefs and dummy fields was chosen over using unions > because of a couple reasons: > * unions cause an extra level of indentation (more likely two levels as > a union containing a struct for multiple fields would be needed). This > makes the lines longer than they need to be and increases the need for > wrapping. [This was the main reason] > * with markers, you can apply multiple markers at the same point if > wanted. > > Signed-off-by: Bruce Richardson Acked-by: Olivier Matz