diff for duplicates of <540DA980.1050708@suse.de> diff --git a/a/1.txt b/N1/1.txt index b8534e3..e652ef4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -60,7 +60,8 @@ On 07.09.14 18:31, Madhavan Srinivasan wrote: > +{ > + u32 last_inst; > + -> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> + EMULATE_DONE) { +> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) != +> + EMULATE_DONE) { > + /* > + * Fetch failed, so return to guest and > + * try executing it again. @@ -71,7 +72,7 @@ Please end the if() here. In the kernel we usually treat abort situations as separate. > + } else { -> + if (last_inst = KVMPPC_INST_SW_BREAKPOINT) { +> + if (last_inst == KVMPPC_INST_SW_BREAKPOINT) { > + run->exit_reason = KVM_EXIT_DEBUG; > + run->debug.arch.address = kvmppc_get_pc(vcpu); > + return RESUME_HOST; @@ -145,7 +146,7 @@ situations as separate. > + * Instruction with primary opcode 0. Based on PowerISA > + * these are illegal instructions. > + */ -> + if(inst = KVMPPC_INST_SW_BREAKPOINT) { +> + if(inst == KVMPPC_INST_SW_BREAKPOINT) { Here you're missing a space between if and (. Are you sure that you ran checkpatch.pl? diff --git a/a/content_digest b/N1/content_digest index efae6a4..d492c7e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,14 +2,14 @@ "ref\01410107494-25556-2-git-send-email-maddy@linux.vnet.ibm.com\0" "From\0Alexander Graf <agraf@suse.de>\0" "Subject\0Re: [PATCH 1/2 v5] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Mon, 08 Sep 2014 13:05:04 +0000\0" + "Date\0Mon, 08 Sep 2014 15:05:04 +0200\0" "To\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>" benh@kernel.crashing.org paulus@samba.org " mpe@ellerman.id.au\0" "Cc\0linuxppc-dev@lists.ozlabs.org" - kvm@vger.kernel.org - " kvm-ppc@vger.kernel.org\0" + kvm-ppc@vger.kernel.org + " kvm@vger.kernel.org\0" "\00:1\0" "b\0" "\n" @@ -74,7 +74,8 @@ "> +{\n" "> +\tu32 last_inst;\n" "> +\n" - "> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> +\t\t\t\t\tEMULATE_DONE) {\n" + "> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !=\n" + "> +\t\t\t\t\tEMULATE_DONE) {\n" "> +\t\t/*\n" "> +\t\t * Fetch failed, so return to guest and\n" "> +\t\t * try executing it again.\n" @@ -85,7 +86,7 @@ "situations as separate.\n" "\n" "> +\t} else {\n" - "> +\t\tif (last_inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + "> +\t\tif (last_inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "> +\t\t\trun->exit_reason = KVM_EXIT_DEBUG;\n" "> +\t\t\trun->debug.arch.address = kvmppc_get_pc(vcpu);\n" "> +\t\t\treturn RESUME_HOST;\n" @@ -159,7 +160,7 @@ "> +\t\t * Instruction with primary opcode 0. Based on PowerISA\n" "> +\t\t * these are illegal instructions.\n" "> +\t\t */\n" - "> +\t\tif(inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + "> +\t\tif(inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "\n" "Here you're missing a space between if and (. Are you sure that you ran\n" "checkpatch.pl?\n" @@ -188,4 +189,4 @@ "> \t}\n" > -394b58d1c0ca134c423bc288bbac822f47d5f9623d5e57630a23247460ae032a +3d8343b49d6b94c3e2e6d3d0b64cb8e5a4e62edb7658e8da683b5b2f2345991e
diff --git a/a/1.txt b/N2/1.txt index b8534e3..e652ef4 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -60,7 +60,8 @@ On 07.09.14 18:31, Madhavan Srinivasan wrote: > +{ > + u32 last_inst; > + -> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> + EMULATE_DONE) { +> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) != +> + EMULATE_DONE) { > + /* > + * Fetch failed, so return to guest and > + * try executing it again. @@ -71,7 +72,7 @@ Please end the if() here. In the kernel we usually treat abort situations as separate. > + } else { -> + if (last_inst = KVMPPC_INST_SW_BREAKPOINT) { +> + if (last_inst == KVMPPC_INST_SW_BREAKPOINT) { > + run->exit_reason = KVM_EXIT_DEBUG; > + run->debug.arch.address = kvmppc_get_pc(vcpu); > + return RESUME_HOST; @@ -145,7 +146,7 @@ situations as separate. > + * Instruction with primary opcode 0. Based on PowerISA > + * these are illegal instructions. > + */ -> + if(inst = KVMPPC_INST_SW_BREAKPOINT) { +> + if(inst == KVMPPC_INST_SW_BREAKPOINT) { Here you're missing a space between if and (. Are you sure that you ran checkpatch.pl? diff --git a/a/content_digest b/N2/content_digest index efae6a4..ec1298e 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\01410107494-25556-2-git-send-email-maddy@linux.vnet.ibm.com\0" "From\0Alexander Graf <agraf@suse.de>\0" "Subject\0Re: [PATCH 1/2 v5] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Mon, 08 Sep 2014 13:05:04 +0000\0" + "Date\0Mon, 08 Sep 2014 15:05:04 +0200\0" "To\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>" benh@kernel.crashing.org paulus@samba.org @@ -74,7 +74,8 @@ "> +{\n" "> +\tu32 last_inst;\n" "> +\n" - "> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> +\t\t\t\t\tEMULATE_DONE) {\n" + "> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !=\n" + "> +\t\t\t\t\tEMULATE_DONE) {\n" "> +\t\t/*\n" "> +\t\t * Fetch failed, so return to guest and\n" "> +\t\t * try executing it again.\n" @@ -85,7 +86,7 @@ "situations as separate.\n" "\n" "> +\t} else {\n" - "> +\t\tif (last_inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + "> +\t\tif (last_inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "> +\t\t\trun->exit_reason = KVM_EXIT_DEBUG;\n" "> +\t\t\trun->debug.arch.address = kvmppc_get_pc(vcpu);\n" "> +\t\t\treturn RESUME_HOST;\n" @@ -159,7 +160,7 @@ "> +\t\t * Instruction with primary opcode 0. Based on PowerISA\n" "> +\t\t * these are illegal instructions.\n" "> +\t\t */\n" - "> +\t\tif(inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + "> +\t\tif(inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "\n" "Here you're missing a space between if and (. Are you sure that you ran\n" "checkpatch.pl?\n" @@ -188,4 +189,4 @@ "> \t}\n" > -394b58d1c0ca134c423bc288bbac822f47d5f9623d5e57630a23247460ae032a +b72919a5b61fd0bf1e78ec1a76606e360b596cfe51253d6454c30e7b6d087f98
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.