From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH v2 1/3] Add vmware_hw to xl.cfg
Date: Mon, 08 Sep 2014 09:56:55 -0400
Message-ID: <540DB5A7.5060804@terremark.com>
References: <1409585629-25840-1-git-send-email-dslutz@verizon.com>	<1409585629-25840-2-git-send-email-dslutz@verizon.com>	<54058DC3020000780002FB1D@mail.emea.novell.com>	<54060B5C.30205@terremark.com>	<5406E32802000078000300E2@mail.emea.novell.com>
	<1410182429.3680.18.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410182429.3680.18.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Eddie Dong <eddie.dong@intel.com>, Tim Deegan <tim@xen.org>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Jun Nakajima <jun.nakajima@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Ian Jackson <ian.jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 09/08/14 09:20, Ian Campbell wrote:
> On Wed, 2014-09-03 at 08:45 +0100, Jan Beulich wrote:
>>>>> On 02.09.14 at 20:24, <dslutz@verizon.com> wrote:
>>> On 09/02/14 03:28, Jan Beulich wrote:
>>>>>>> On 01.09.14 at 17:33, <dslutz@verizon.com> wrote:
>>>>> So based on this, I picked the order:
>>>>>
>>>>> 0x40000000 is viridian, vmware or xen
>>>>> 0x40000100 is vmware or xen
>>>>> 0x40000200 is xen
>>>> Is there really a point in enabling both Viridian and VMware extensions
>>>> at the same time?
>>> Not that I know of (and I do not want to say there there is no code
>>> out there that can work with both).  Instead of an error or warning
>>> I went with what xen is currently doing and that seabios was happy
>>> to find xen at 0x40000200.
>>>
>>> If the consensus is to ignore, or report an error or warning I will go that
>>> way.  For now I am not planning on changing.
>> My personal take on this is that the hypervisor (or perhaps already
>> the tools) should reject enabling both at the same time.
> That sounds sensible to me.
>
> Generally we seem to have the hypervisor check these things as a
> backstop, to stop broken tools, but also check in the tools so we can
> give a better error message.
>

Ok, with 2 votes this way how about (for v4) I will drop the change to
xen/arch/x86/traps.c (I.E. 0x40000100 will be xen)  And change

cpuid_vmware_leaves to return 0 if is_viridian_domain().

And add some logic in the and doc in the tools patch to do this error
message.

    -Don Slutz

>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel