From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Michel_D=E4nzer?= <michel@daenzer.net>
Subject: Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO
 creation flag
Date: Tue, 09 Sep 2014 09:47:36 +0900
Message-ID: <540E4E28.50701@daenzer.net>
References: <1409208961-7322-1-git-send-email-michel@daenzer.net>
 <53FEEEF4.7030401@vodafone.de>
 <CADnq5_N5gf_+4eVHfu4-sQ8DufsVfg7Y28qxBY3wvARpQcDkEA@mail.gmail.com>
 <53FFDB6B.5050105@daenzer.net>
 <CADnq5_PjfMrdw4oRZOGyRvU5BLbiVLHpSeLZ+-sC4ChEu8bf2w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <CADnq5_PjfMrdw4oRZOGyRvU5BLbiVLHpSeLZ+-sC4ChEu8bf2w@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "mesa-dev@lists.freedesktop.org" <mesa-dev@lists.freedesktop.org>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On 09.09.2014 02:36, Alex Deucher wrote:
>
> Updated version with comments integrated.

[...]

> @@ -314,10 +314,12 @@ int radeon_bo_pin_restricted(struct radeon_bo *bo, =
u32 domain, u64 max_offset,
>  		unsigned lpfn =3D 0;
>
>  		/* force to pin into visible video ram */
> -		if (bo->placements[i].flags & TTM_PL_FLAG_VRAM)
> -			lpfn =3D bo->rdev->mc.visible_vram_size >> PAGE_SHIFT;
> -		else
> +		if (bo->placements[i].flags & TTM_PL_FLAG_VRAM) {
> +			if (!(bo->flags & RADEON_GEM_NO_CPU_ACCESS))
> +				lpfn =3D bo->rdev->mc.visible_vram_size >> PAGE_SHIFT;
> +		} else {
>  			lpfn =3D bo->rdev->mc.gtt_size >> PAGE_SHIFT; /* ??? */
> +		}

The else block can be removed as well, but that can be done in another =

patch.

Either way, v2 is

Reviewed-by: Michel D=E4nzer <michel.daenzer@amd.com>


-- =

Earthling Michel D=E4nzer            |                  http://www.amd.com
Libre software enthusiast          |                Mesa and X developer