diff for duplicates of <540EACB4.6040009@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index d896246..67ca2dd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -61,7 +61,8 @@ On Monday 08 September 2014 06:35 PM, Alexander Graf wrote: >> +{ >> + u32 last_inst; >> + ->> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !>> + EMULATE_DONE) { +>> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) != +>> + EMULATE_DONE) { >> + /* >> + * Fetch failed, so return to guest and >> + * try executing it again. @@ -75,7 +76,7 @@ On Monday 08 September 2014 06:35 PM, Alexander Graf wrote: OK. Will change it. >> + } else { ->> + if (last_inst = KVMPPC_INST_SW_BREAKPOINT) { +>> + if (last_inst == KVMPPC_INST_SW_BREAKPOINT) { >> + run->exit_reason = KVM_EXIT_DEBUG; >> + run->debug.arch.address = kvmppc_get_pc(vcpu); >> + return RESUME_HOST; @@ -149,7 +150,7 @@ OK. Will change it. >> + * Instruction with primary opcode 0. Based on PowerISA >> + * these are illegal instructions. >> + */ ->> + if(inst = KVMPPC_INST_SW_BREAKPOINT) { +>> + if(inst == KVMPPC_INST_SW_BREAKPOINT) { > > Here you're missing a space between if and (. Are you sure that you ran > checkpatch.pl? diff --git a/a/content_digest b/N1/content_digest index 4a77707..de4b1ec 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,14 +3,14 @@ "ref\0540DA980.1050708@suse.de\0" "From\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>\0" "Subject\0Re: [PATCH 1/2 v5] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Tue, 09 Sep 2014 07:43:00 +0000\0" + "Date\0Tue, 09 Sep 2014 13:01:00 +0530\0" "To\0Alexander Graf <agraf@suse.de>" benh@kernel.crashing.org paulus@samba.org " mpe@ellerman.id.au\0" "Cc\0linuxppc-dev@lists.ozlabs.org" - kvm@vger.kernel.org - " kvm-ppc@vger.kernel.org\0" + kvm-ppc@vger.kernel.org + " kvm@vger.kernel.org\0" "\00:1\0" "b\0" "On Monday 08 September 2014 06:35 PM, Alexander Graf wrote:\n" @@ -76,7 +76,8 @@ ">> +{\n" ">> +\tu32 last_inst;\n" ">> +\n" - ">> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !>> +\t\t\t\t\tEMULATE_DONE) {\n" + ">> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !=\n" + ">> +\t\t\t\t\tEMULATE_DONE) {\n" ">> +\t\t/*\n" ">> +\t\t * Fetch failed, so return to guest and\n" ">> +\t\t * try executing it again.\n" @@ -90,7 +91,7 @@ "OK. Will change it.\n" "\n" ">> +\t} else {\n" - ">> +\t\tif (last_inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + ">> +\t\tif (last_inst == KVMPPC_INST_SW_BREAKPOINT) {\n" ">> +\t\t\trun->exit_reason = KVM_EXIT_DEBUG;\n" ">> +\t\t\trun->debug.arch.address = kvmppc_get_pc(vcpu);\n" ">> +\t\t\treturn RESUME_HOST;\n" @@ -164,7 +165,7 @@ ">> +\t\t * Instruction with primary opcode 0. Based on PowerISA\n" ">> +\t\t * these are illegal instructions.\n" ">> +\t\t */\n" - ">> +\t\tif(inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + ">> +\t\tif(inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "> \n" "> Here you're missing a space between if and (. Are you sure that you ran\n" "> checkpatch.pl?\n" @@ -203,4 +204,4 @@ ">>\n" > -15ad8472eb8020c842d599b410773850b78375e2232d120d47e0260bb833a532 +9c25c7aacac4e2b7a560853edc19b294ebfe98f885ff5fb629f50e4563e0c0fc
diff --git a/a/1.txt b/N2/1.txt index d896246..67ca2dd 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -61,7 +61,8 @@ On Monday 08 September 2014 06:35 PM, Alexander Graf wrote: >> +{ >> + u32 last_inst; >> + ->> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !>> + EMULATE_DONE) { +>> + if(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) != +>> + EMULATE_DONE) { >> + /* >> + * Fetch failed, so return to guest and >> + * try executing it again. @@ -75,7 +76,7 @@ On Monday 08 September 2014 06:35 PM, Alexander Graf wrote: OK. Will change it. >> + } else { ->> + if (last_inst = KVMPPC_INST_SW_BREAKPOINT) { +>> + if (last_inst == KVMPPC_INST_SW_BREAKPOINT) { >> + run->exit_reason = KVM_EXIT_DEBUG; >> + run->debug.arch.address = kvmppc_get_pc(vcpu); >> + return RESUME_HOST; @@ -149,7 +150,7 @@ OK. Will change it. >> + * Instruction with primary opcode 0. Based on PowerISA >> + * these are illegal instructions. >> + */ ->> + if(inst = KVMPPC_INST_SW_BREAKPOINT) { +>> + if(inst == KVMPPC_INST_SW_BREAKPOINT) { > > Here you're missing a space between if and (. Are you sure that you ran > checkpatch.pl? diff --git a/a/content_digest b/N2/content_digest index 4a77707..1e3aa3b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\0540DA980.1050708@suse.de\0" "From\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>\0" "Subject\0Re: [PATCH 1/2 v5] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Tue, 09 Sep 2014 07:43:00 +0000\0" + "Date\0Tue, 09 Sep 2014 13:01:00 +0530\0" "To\0Alexander Graf <agraf@suse.de>" benh@kernel.crashing.org paulus@samba.org @@ -76,7 +76,8 @@ ">> +{\n" ">> +\tu32 last_inst;\n" ">> +\n" - ">> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !>> +\t\t\t\t\tEMULATE_DONE) {\n" + ">> +\tif(kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !=\n" + ">> +\t\t\t\t\tEMULATE_DONE) {\n" ">> +\t\t/*\n" ">> +\t\t * Fetch failed, so return to guest and\n" ">> +\t\t * try executing it again.\n" @@ -90,7 +91,7 @@ "OK. Will change it.\n" "\n" ">> +\t} else {\n" - ">> +\t\tif (last_inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + ">> +\t\tif (last_inst == KVMPPC_INST_SW_BREAKPOINT) {\n" ">> +\t\t\trun->exit_reason = KVM_EXIT_DEBUG;\n" ">> +\t\t\trun->debug.arch.address = kvmppc_get_pc(vcpu);\n" ">> +\t\t\treturn RESUME_HOST;\n" @@ -164,7 +165,7 @@ ">> +\t\t * Instruction with primary opcode 0. Based on PowerISA\n" ">> +\t\t * these are illegal instructions.\n" ">> +\t\t */\n" - ">> +\t\tif(inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + ">> +\t\tif(inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "> \n" "> Here you're missing a space between if and (. Are you sure that you ran\n" "> checkpatch.pl?\n" @@ -203,4 +204,4 @@ ">>\n" > -15ad8472eb8020c842d599b410773850b78375e2232d120d47e0260bb833a532 +80fd12294e6896b7b79832770f702a6ba8a7f99d72766d7c9fa0d40383d99e2e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.