From mboxrd@z Thu Jan 1 00:00:00 1970 From: Madhavan Srinivasan Date: Tue, 09 Sep 2014 07:53:08 +0000 Subject: Re: [PATCH 2/2 v5] powerpc/kvm: common sw breakpoint instr across ppc Message-Id: <540EAF14.8050201@linux.vnet.ibm.com> List-Id: References: <1410107494-25556-1-git-send-email-maddy@linux.vnet.ibm.com> <1410107494-25556-3-git-send-email-maddy@linux.vnet.ibm.com> <540DAA9E.1070102@suse.de> In-Reply-To: <540DAA9E.1070102@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org On Monday 08 September 2014 06:39 PM, Alexander Graf wrote: > > > On 07.09.14 18:31, Madhavan Srinivasan wrote: >> This patch extends the use of illegal instruction as software >> breakpoint instruction across the ppc platform. Patch extends >> booke program interrupt code to support software breakpoint. >> >> Signed-off-by: Madhavan Srinivasan >> --- >> >> Patch is only compile tested. Will really help if >> someone can try it out and let me know comments. >> >> arch/powerpc/kvm/booke.c | 18 ++++++++++++++++-- >> 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c >> index b4c89fa..1b84853 100644 >> --- a/arch/powerpc/kvm/booke.c >> +++ b/arch/powerpc/kvm/booke.c >> @@ -870,6 +870,10 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu, >> case BOOKE_INTERRUPT_HV_PRIV: >> emulated = kvmppc_get_last_inst(vcpu, false, &last_inst); >> break; >> + case BOOKE_INTERRUPT_PROGRAM: >> + /*SW breakpoints arrive as illegal instructions on HV */ > > Is it my email client or is there a space missing again? ;) > Facepalm. Will fix it. > Also, please only fetch the last instruction if debugging is active. > Will change it. >> + emulated = kvmppc_get_last_inst(vcpu, false, &last_inst); >> + break; >> default: >> break; >> } >> @@ -947,7 +951,17 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu, >> break; >> >> case BOOKE_INTERRUPT_PROGRAM: >> - if (vcpu->arch.shared->msr & (MSR_PR | MSR_GS)) { >> + if ((vcpu->arch.shared->msr & (MSR_PR | MSR_GS)) && >> + (last_inst = KVMPPC_INST_SW_BREAKPOINT)) { > > I think this is changing the logic from "if the guest is in user mode or > we're in HV, deflect" to "if the guest is in user mode or an HV guest > and the instruction is a breakpoint, treat it as debug. Otherwise > deflect". So you're essentially breaking PR KVM here from what I can tell. > > Why don't you just split the whole thing out to the beginning of > BOOKE_INTERRUPT_PROGRAM and check for > > a) debug is enabled > b) instruction is sw breakpoint > This is what we pretty much do for the server side. Will changes it. > instead? > >> + /* >> + * We are here because of an SW breakpoint instr, >> + * so lets return to host to handle. >> + */ >> + r = kvmppc_handle_debug(run, vcpu); >> + run->exit_reason = KVM_EXIT_DEBUG; >> + kvmppc_account_exit(vcpu, DEBUG_EXITS); >> + break; >> + } else { >> /* >> * Program traps generated by user-level software must >> * be handled by the guest kernel. >> @@ -1505,7 +1519,7 @@ int kvm_vcpu_ioctl_get_one_reg(struct kvm_vcpu *vcpu, struct kvm_one_reg *reg) >> val = get_reg_val(reg->id, vcpu->arch.tsr); >> break; >> case KVM_REG_PPC_DEBUG_INST: >> - val = get_reg_val(reg->id, KVMPPC_INST_EHPRIV_DEBUG); > > Please also remove the definition of EHPRIV_DEBUG. > OK. Will do. Thanks for review Maddy > > Alex > >> + val = get_reg_val(reg->id, KVMPPC_INST_SW_BREAKPOINT); >> break; >> case KVM_REG_PPC_VRSAVE: >> val = get_reg_val(reg->id, vcpu->arch.vrsave); >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id B158A1A0053 for ; Tue, 9 Sep 2014 17:41:22 +1000 (EST) Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 9 Sep 2014 17:41:22 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 9797A2BB0051 for ; Tue, 9 Sep 2014 17:41:18 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay04.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s897NO6L59441390 for ; Tue, 9 Sep 2014 17:23:24 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s897fH9j004864 for ; Tue, 9 Sep 2014 17:41:18 +1000 Message-ID: <540EAF14.8050201@linux.vnet.ibm.com> Date: Tue, 09 Sep 2014 13:11:08 +0530 From: Madhavan Srinivasan MIME-Version: 1.0 To: Alexander Graf , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au Subject: Re: [PATCH 2/2 v5] powerpc/kvm: common sw breakpoint instr across ppc References: <1410107494-25556-1-git-send-email-maddy@linux.vnet.ibm.com> <1410107494-25556-3-git-send-email-maddy@linux.vnet.ibm.com> <540DAA9E.1070102@suse.de> In-Reply-To: <540DAA9E.1070102@suse.de> Content-Type: text/plain; charset=windows-1252 Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Monday 08 September 2014 06:39 PM, Alexander Graf wrote: > > > On 07.09.14 18:31, Madhavan Srinivasan wrote: >> This patch extends the use of illegal instruction as software >> breakpoint instruction across the ppc platform. Patch extends >> booke program interrupt code to support software breakpoint. >> >> Signed-off-by: Madhavan Srinivasan >> --- >> >> Patch is only compile tested. Will really help if >> someone can try it out and let me know comments. >> >> arch/powerpc/kvm/booke.c | 18 ++++++++++++++++-- >> 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c >> index b4c89fa..1b84853 100644 >> --- a/arch/powerpc/kvm/booke.c >> +++ b/arch/powerpc/kvm/booke.c >> @@ -870,6 +870,10 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu, >> case BOOKE_INTERRUPT_HV_PRIV: >> emulated = kvmppc_get_last_inst(vcpu, false, &last_inst); >> break; >> + case BOOKE_INTERRUPT_PROGRAM: >> + /*SW breakpoints arrive as illegal instructions on HV */ > > Is it my email client or is there a space missing again? ;) > Facepalm. Will fix it. > Also, please only fetch the last instruction if debugging is active. > Will change it. >> + emulated = kvmppc_get_last_inst(vcpu, false, &last_inst); >> + break; >> default: >> break; >> } >> @@ -947,7 +951,17 @@ int kvmppc_handle_exit(struct kvm_run *run, struct kvm_vcpu *vcpu, >> break; >> >> case BOOKE_INTERRUPT_PROGRAM: >> - if (vcpu->arch.shared->msr & (MSR_PR | MSR_GS)) { >> + if ((vcpu->arch.shared->msr & (MSR_PR | MSR_GS)) && >> + (last_inst == KVMPPC_INST_SW_BREAKPOINT)) { > > I think this is changing the logic from "if the guest is in user mode or > we're in HV, deflect" to "if the guest is in user mode or an HV guest > and the instruction is a breakpoint, treat it as debug. Otherwise > deflect". So you're essentially breaking PR KVM here from what I can tell. > > Why don't you just split the whole thing out to the beginning of > BOOKE_INTERRUPT_PROGRAM and check for > > a) debug is enabled > b) instruction is sw breakpoint > This is what we pretty much do for the server side. Will changes it. > instead? > >> + /* >> + * We are here because of an SW breakpoint instr, >> + * so lets return to host to handle. >> + */ >> + r = kvmppc_handle_debug(run, vcpu); >> + run->exit_reason = KVM_EXIT_DEBUG; >> + kvmppc_account_exit(vcpu, DEBUG_EXITS); >> + break; >> + } else { >> /* >> * Program traps generated by user-level software must >> * be handled by the guest kernel. >> @@ -1505,7 +1519,7 @@ int kvm_vcpu_ioctl_get_one_reg(struct kvm_vcpu *vcpu, struct kvm_one_reg *reg) >> val = get_reg_val(reg->id, vcpu->arch.tsr); >> break; >> case KVM_REG_PPC_DEBUG_INST: >> - val = get_reg_val(reg->id, KVMPPC_INST_EHPRIV_DEBUG); > > Please also remove the definition of EHPRIV_DEBUG. > OK. Will do. Thanks for review Maddy > > Alex > >> + val = get_reg_val(reg->id, KVMPPC_INST_SW_BREAKPOINT); >> break; >> case KVM_REG_PPC_VRSAVE: >> val = get_reg_val(reg->id, vcpu->arch.vrsave); >> > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Madhavan Srinivasan Subject: Re: [PATCH 2/2 v5] powerpc/kvm: common sw breakpoint instr across ppc Date: Tue, 09 Sep 2014 13:11:08 +0530 Message-ID: <540EAF14.8050201@linux.vnet.ibm.com> References: <1410107494-25556-1-git-send-email-maddy@linux.vnet.ibm.com> <1410107494-25556-3-git-send-email-maddy@linux.vnet.ibm.com> <540DAA9E.1070102@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: Alexander Graf , benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au Return-path: In-Reply-To: <540DAA9E.1070102@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org T24gTW9uZGF5IDA4IFNlcHRlbWJlciAyMDE0IDA2OjM5IFBNLCBBbGV4YW5kZXIgR3JhZiB3cm90 ZToKPiAKPiAKPiBPbiAwNy4wOS4xNCAxODozMSwgTWFkaGF2YW4gU3Jpbml2YXNhbiB3cm90ZToK Pj4gVGhpcyBwYXRjaCBleHRlbmRzIHRoZSB1c2Ugb2YgaWxsZWdhbCBpbnN0cnVjdGlvbiBhcyBz b2Z0d2FyZQo+PiBicmVha3BvaW50IGluc3RydWN0aW9uIGFjcm9zcyB0aGUgcHBjIHBsYXRmb3Jt LiBQYXRjaCBleHRlbmRzCj4+IGJvb2tlIHByb2dyYW0gaW50ZXJydXB0IGNvZGUgdG8gc3VwcG9y dCBzb2Z0d2FyZSBicmVha3BvaW50Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNYWRoYXZhbiBTcmlu aXZhc2FuIDxtYWRkeUBsaW51eC52bmV0LmlibS5jb20+Cj4+IC0tLQo+Pgo+PiBQYXRjaCBpcyBv bmx5IGNvbXBpbGUgdGVzdGVkLiBXaWxsIHJlYWxseSBoZWxwIGlmCj4+IHNvbWVvbmUgY2FuIHRy eSBpdCBvdXQgYW5kIGxldCBtZSBrbm93IGNvbW1lbnRzLgo+Pgo+PiAgYXJjaC9wb3dlcnBjL2t2 bS9ib29rZS5jIHwgMTggKysrKysrKysrKysrKysrKy0tCj4+ICAxIGZpbGUgY2hhbmdlZCwgMTYg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2FyY2gvcG93 ZXJwYy9rdm0vYm9va2UuYyBiL2FyY2gvcG93ZXJwYy9rdm0vYm9va2UuYwo+PiBpbmRleCBiNGM4 OWZhLi4xYjg0ODUzIDEwMDY0NAo+PiAtLS0gYS9hcmNoL3Bvd2VycGMva3ZtL2Jvb2tlLmMKPj4g KysrIGIvYXJjaC9wb3dlcnBjL2t2bS9ib29rZS5jCj4+IEBAIC04NzAsNiArODcwLDEwIEBAIGlu dCBrdm1wcGNfaGFuZGxlX2V4aXQoc3RydWN0IGt2bV9ydW4gKnJ1biwgc3RydWN0IGt2bV92Y3B1 ICp2Y3B1LAo+PiAgCWNhc2UgQk9PS0VfSU5URVJSVVBUX0hWX1BSSVY6Cj4+ICAJCWVtdWxhdGVk ID0ga3ZtcHBjX2dldF9sYXN0X2luc3QodmNwdSwgZmFsc2UsICZsYXN0X2luc3QpOwo+PiAgCQli cmVhazsKPj4gKwljYXNlIEJPT0tFX0lOVEVSUlVQVF9QUk9HUkFNOgo+PiArCQkvKlNXIGJyZWFr cG9pbnRzIGFycml2ZSBhcyBpbGxlZ2FsIGluc3RydWN0aW9ucyBvbiBIViAqLwo+IAo+IElzIGl0 IG15IGVtYWlsIGNsaWVudCBvciBpcyB0aGVyZSBhIHNwYWNlIG1pc3NpbmcgYWdhaW4/IDspCj4g CgpGYWNlcGFsbS4gV2lsbCBmaXggaXQuCgo+IEFsc28sIHBsZWFzZSBvbmx5IGZldGNoIHRoZSBs YXN0IGluc3RydWN0aW9uIGlmIGRlYnVnZ2luZyBpcyBhY3RpdmUuCj4gCgpXaWxsIGNoYW5nZSBp dC4KCj4+ICsJCWVtdWxhdGVkID0ga3ZtcHBjX2dldF9sYXN0X2luc3QodmNwdSwgZmFsc2UsICZs YXN0X2luc3QpOwo+PiArCQlicmVhazsKPj4gIAlkZWZhdWx0Ogo+PiAgCQlicmVhazsKPj4gIAl9 Cj4+IEBAIC05NDcsNyArOTUxLDE3IEBAIGludCBrdm1wcGNfaGFuZGxlX2V4aXQoc3RydWN0IGt2 bV9ydW4gKnJ1biwgc3RydWN0IGt2bV92Y3B1ICp2Y3B1LAo+PiAgCQlicmVhazsKPj4gIAo+PiAg CWNhc2UgQk9PS0VfSU5URVJSVVBUX1BST0dSQU06Cj4+IC0JCWlmICh2Y3B1LT5hcmNoLnNoYXJl ZC0+bXNyICYgKE1TUl9QUiB8IE1TUl9HUykpIHsKPj4gKwkJaWYgKCh2Y3B1LT5hcmNoLnNoYXJl ZC0+bXNyICYgKE1TUl9QUiB8IE1TUl9HUykpICYmCj4+ICsJCQkobGFzdF9pbnN0ID09IEtWTVBQ Q19JTlNUX1NXX0JSRUFLUE9JTlQpKSB7Cj4gCj4gSSB0aGluayB0aGlzIGlzIGNoYW5naW5nIHRo ZSBsb2dpYyBmcm9tICJpZiB0aGUgZ3Vlc3QgaXMgaW4gdXNlciBtb2RlIG9yCj4gd2UncmUgaW4g SFYsIGRlZmxlY3QiIHRvICJpZiB0aGUgZ3Vlc3QgaXMgaW4gdXNlciBtb2RlIG9yIGFuIEhWIGd1 ZXN0Cj4gYW5kIHRoZSBpbnN0cnVjdGlvbiBpcyBhIGJyZWFrcG9pbnQsIHRyZWF0IGl0IGFzIGRl YnVnLiBPdGhlcndpc2UKPiBkZWZsZWN0Ii4gU28geW91J3JlIGVzc2VudGlhbGx5IGJyZWFraW5n IFBSIEtWTSBoZXJlIGZyb20gd2hhdCBJIGNhbiB0ZWxsLgo+IAo+IFdoeSBkb24ndCB5b3UganVz dCBzcGxpdCB0aGUgd2hvbGUgdGhpbmcgb3V0IHRvIHRoZSBiZWdpbm5pbmcgb2YKPiBCT09LRV9J TlRFUlJVUFRfUFJPR1JBTSBhbmQgY2hlY2sgZm9yCj4gCj4gICBhKSBkZWJ1ZyBpcyBlbmFibGVk Cj4gICBiKSBpbnN0cnVjdGlvbiBpcyBzdyBicmVha3BvaW50Cj4gClRoaXMgaXMgd2hhdCB3ZSBw cmV0dHkgbXVjaCBkbyBmb3IgdGhlIHNlcnZlciBzaWRlLiBXaWxsIGNoYW5nZXMgaXQuCgo+IGlu c3RlYWQ/Cj4gCj4+ICsJCQkvKgo+PiArCQkJICogV2UgYXJlIGhlcmUgYmVjYXVzZSBvZiBhbiBT VyBicmVha3BvaW50IGluc3RyLAo+PiArCQkJICogc28gbGV0cyByZXR1cm4gdG8gaG9zdCB0byBo YW5kbGUuCj4+ICsJCQkgKi8KPj4gKwkJCXIgPSBrdm1wcGNfaGFuZGxlX2RlYnVnKHJ1biwgdmNw dSk7Cj4+ICsJCQlydW4tPmV4aXRfcmVhc29uID0gS1ZNX0VYSVRfREVCVUc7Cj4+ICsJCQlrdm1w cGNfYWNjb3VudF9leGl0KHZjcHUsIERFQlVHX0VYSVRTKTsKPj4gKwkJCWJyZWFrOwo+PiArCQl9 IGVsc2UgewkKPj4gIAkJCS8qCj4+ICAJCQkgKiBQcm9ncmFtIHRyYXBzIGdlbmVyYXRlZCBieSB1 c2VyLWxldmVsIHNvZnR3YXJlIG11c3QKPj4gIAkJCSAqIGJlIGhhbmRsZWQgYnkgdGhlIGd1ZXN0 IGtlcm5lbC4KPj4gQEAgLTE1MDUsNyArMTUxOSw3IEBAIGludCBrdm1fdmNwdV9pb2N0bF9nZXRf b25lX3JlZyhzdHJ1Y3Qga3ZtX3ZjcHUgKnZjcHUsIHN0cnVjdCBrdm1fb25lX3JlZyAqcmVnKQo+ PiAgCQl2YWwgPSBnZXRfcmVnX3ZhbChyZWctPmlkLCB2Y3B1LT5hcmNoLnRzcik7Cj4+ICAJCWJy ZWFrOwo+PiAgCWNhc2UgS1ZNX1JFR19QUENfREVCVUdfSU5TVDoKPj4gLQkJdmFsID0gZ2V0X3Jl Z192YWwocmVnLT5pZCwgS1ZNUFBDX0lOU1RfRUhQUklWX0RFQlVHKTsKPiAKPiBQbGVhc2UgYWxz byByZW1vdmUgdGhlIGRlZmluaXRpb24gb2YgRUhQUklWX0RFQlVHLgo+IApPSy4gV2lsbCBkby4K CgpUaGFua3MgZm9yIHJldmlldwpNYWRkeQoKPiAKPiBBbGV4Cj4gCj4+ICsJCXZhbCA9IGdldF9y ZWdfdmFsKHJlZy0+aWQsIEtWTVBQQ19JTlNUX1NXX0JSRUFLUE9JTlQpOwo+PiAgCQlicmVhazsK Pj4gIAljYXNlIEtWTV9SRUdfUFBDX1ZSU0FWRToKPj4gIAkJdmFsID0gZ2V0X3JlZ192YWwocmVn LT5pZCwgdmNwdS0+YXJjaC52cnNhdmUpOwo+Pgo+IAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApMaW51eHBw Yy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8v bGludXhwcGMtZGV2