All of lore.kernel.org
 help / color / mirror / Atom feed
From: jiwang <jiada_wang@mentor.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.de>,
	"Frkuska, Joshua" <Joshua_Frkuska@mentor.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: question about two ASoC commits
Date: Tue, 9 Sep 2014 17:36:36 +0900	[thread overview]
Message-ID: <540EBC14.6090002@mentor.com> (raw)

Hi

Can anyone tell me what is the reasoning of the following two commits
commit: 5d16333 ASoC: SND_SOC_DAIFMT_NB_NF become 0 as default settings
commit: eef28e1 ASoC: SND_SOC_DAIFMT_GATED become 0 as default settings

with these two commits, now we have
#define SND_SOC_DAIFMT_GATED            (0 << 4)
#define SND_SOC_DAIFMT_NB_NF            (0 << 8)
in soc-dai.h
what's the good to shift 0 with different numbers?
no matter the number, they both equal to 0.

IMO all bit flags which share same variable (in this case SND_SOC_DAIFMT)
should have different value, isn't it?

Thanks,
Jiada

             reply	other threads:[~2014-09-09  8:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  8:36 jiwang [this message]
2014-09-09 10:19 ` question about two ASoC commits Mark Brown
     [not found]   ` <857E9EDCA6C0904DB3357321AA9123EBE61DF1E9@NA-MBX-01.mgc.mentorg.com>
2014-09-10  5:17     ` jiwang
2014-09-10 10:11       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540EBC14.6090002@mentor.com \
    --to=jiada_wang@mentor.com \
    --cc=Joshua_Frkuska@mentor.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.