From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V4 4/5] xen, libxc: Request page fault injection via libxc Date: Tue, 09 Sep 2014 13:31:36 +0300 Message-ID: <540ED708.6070702@bitdefender.com> References: <1409911297-3360-1-git-send-email-rcojocaru@bitdefender.com> <1409911297-3360-5-git-send-email-rcojocaru@bitdefender.com> <540DEB9702000078000322A5@mail.emea.novell.com> <540DD793.9060101@bitdefender.com> <540EDF9C02000078000326CA@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XRIi7-0007nb-GO for xen-devel@lists.xenproject.org; Tue, 09 Sep 2014 10:31:43 +0000 Received: from smtp03.buh.bitdefender.org (smtp.bitdefender.biz [10.17.80.77]) by mx-sr.buh.bitdefender.com (Postfix) with ESMTP id 712F280066 for ; Tue, 9 Sep 2014 13:31:40 +0300 (EEST) In-Reply-To: <540EDF9C02000078000326CA@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, keir@xen.org, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, eddie.dong@intel.com, tim@xen.org, jun.nakajima@intel.com, xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 09/09/2014 12:08 PM, Jan Beulich wrote: >>>> On 08.09.14 at 18:21, wrote: >> On 09/08/14 18:47, Jan Beulich wrote: >>>>>> On 05.09.14 at 12:01, wrote: >>>> + { >>>> + hvm_inject_trap(&d->arch.hvm_domain.inject_trap); >>>> + d->arch.hvm_domain.inject_trap.vector = -1; >>>> + } >>> >>> And this is clearly lacking serialization (or a comment saying why >>> serialization isn't needed here). >> >> If I understood this correctly, this is what Kevin has recommended: that >> only one HVMOP_trap_request should be pending at a time. Or have I >> misunderstood your comment? > > Indeed you have - the comment is about dealing with races of e.g. > two CPUs processing a request for trap injection at the same time. Thanks for clearing that up. I hope I've addressed all these issues in V6 (just posted), and hopefully patch 5/5 can also be Acked now (I'm now using struct npfec as discussed). Thanks, Razvan Cojocaru