From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla) Date: Tue, 09 Sep 2014 12:27:22 +0100 Subject: [PATCH v2] pinctrl: st: remove gpiochip in failure cases In-Reply-To: <1410249101-12234-1-git-send-email-pramod.gurav@smartplayin.com> References: <1410249101-12234-1-git-send-email-pramod.gurav@smartplayin.com> Message-ID: <540EE41A.2070807@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Acked-by: Srinivas Kandagatla On 09/09/14 08:51, Pramod Gurav wrote: > This patch releases gpiochip related resources by calling > gpiochip_remove when gpiochip_irqchip_add fails. > > CC: Srinivas Kandagatla > CC: Srinivas Kandagatla > CC: Maxime Coquelin > CC: Patrice Chotard > CC: Linus Walleij > CC: Bjorn Andersson > > Signed-off-by: Pramod Gurav > --- > Changes since v1: > Dropped adding remove function as it will never be tested as > the driver is bool. > > drivers/pinctrl/pinctrl-st.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 5475374..af2f589 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1517,6 +1517,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info, > 0, handle_simple_irq, > IRQ_TYPE_LEVEL_LOW); > if (err) { > + gpiochip_remove(&bank->gpio_chip); > dev_info(dev, "could not add irqchip\n"); > return err; > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756503AbaIIL10 (ORCPT ); Tue, 9 Sep 2014 07:27:26 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:56124 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753423AbaIIL1Z (ORCPT ); Tue, 9 Sep 2014 07:27:25 -0400 Message-ID: <540EE41A.2070807@linaro.org> Date: Tue, 09 Sep 2014 12:27:22 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Pramod Gurav , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@stlinux.com CC: Srinivas Kandagatla , Srinivas Kandagatla , Maxime Coquelin , Patrice Chotard , Linus Walleij , Bjorn Andersson Subject: Re: [PATCH v2] pinctrl: st: remove gpiochip in failure cases References: <1410249101-12234-1-git-send-email-pramod.gurav@smartplayin.com> In-Reply-To: <1410249101-12234-1-git-send-email-pramod.gurav@smartplayin.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Srinivas Kandagatla On 09/09/14 08:51, Pramod Gurav wrote: > This patch releases gpiochip related resources by calling > gpiochip_remove when gpiochip_irqchip_add fails. > > CC: Srinivas Kandagatla > CC: Srinivas Kandagatla > CC: Maxime Coquelin > CC: Patrice Chotard > CC: Linus Walleij > CC: Bjorn Andersson > > Signed-off-by: Pramod Gurav > --- > Changes since v1: > Dropped adding remove function as it will never be tested as > the driver is bool. > > drivers/pinctrl/pinctrl-st.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 5475374..af2f589 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1517,6 +1517,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info, > 0, handle_simple_irq, > IRQ_TYPE_LEVEL_LOW); > if (err) { > + gpiochip_remove(&bank->gpio_chip); > dev_info(dev, "could not add irqchip\n"); > return err; > } >