From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRNrL-000556-6U for qemu-devel@nongnu.org; Tue, 09 Sep 2014 12:01:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRNrE-0005bo-U6 for qemu-devel@nongnu.org; Tue, 09 Sep 2014 12:01:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRNrE-0005bi-MD for qemu-devel@nongnu.org; Tue, 09 Sep 2014 12:01:28 -0400 Message-ID: <540F23F6.8080407@redhat.com> Date: Tue, 09 Sep 2014 17:59:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1410249273-6063-1-git-send-email-eric.auger@linaro.org> <1410249273-6063-2-git-send-email-eric.auger@linaro.org> <540EDCF9.7070609@redhat.com> <540F1BF2.4080505@linaro.org> In-Reply-To: <540F1BF2.4080505@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/6] hw/misc/dyn_sysbus_binding: helpers for sysbus device dynamic binding List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Auger , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, a.rigo@virtualopensystems.com, kim.phillips@freescale.com, marc.zyngier@arm.com, manish.jaggi@caviumnetworks.com, joel.schopp@amd.com, agraf@suse.de, peter.maydell@linaro.org, afaerber@suse.de Cc: patches@linaro.org, will.deacon@arm.com, stuart.yoder@freescale.com, Bharat.Bhushan@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu Il 09/09/2014 17:25, Eric Auger ha scritto: >> > >> > Please provide a wrapper like sysbus_register_dynamic that takes the >> > params/address_space_mem/mpic as parameter. platform_bus_init_notify >> > and DynSysbusNotifier can remain hidden within the .c file. > Sorry I do not catch what you mean here. platform_bus_init_notify & > DynSysbusNotifier are currently used in virt.c to initialize & register > the machine_init_done_notifier. Yeah, please do the registration in sysbus.c, not in virt.c. There is no reason to make the platform_bus_init_notify+DynSysbusNotifier interface public. The code in sysbus.c can fill in the fields. Paolo