From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [net-next PATCH v3 05/15] net: sched: cls_flow use RCU Date: Tue, 09 Sep 2014 09:09:36 -0700 Message-ID: <540F2640.2080904@gmail.com> References: <20140909055221.2071.99671.stgit@nitbit.x32> <20140909055601.2071.43459.stgit@nitbit.x32> <1410266481.11872.158.camel@edumazet-glaptop2.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: xiyou.wangcong@gmail.com, davem@davemloft.net, jhs@mojatatu.com, netdev@vger.kernel.org, paulmck@linux.vnet.ibm.com, brouer@redhat.com To: Eric Dumazet Return-path: Received: from mail-oa0-f46.google.com ([209.85.219.46]:40451 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402AbaIIQJ4 (ORCPT ); Tue, 9 Sep 2014 12:09:56 -0400 Received: by mail-oa0-f46.google.com with SMTP id eb12so2988119oac.33 for ; Tue, 09 Sep 2014 09:09:55 -0700 (PDT) In-Reply-To: <1410266481.11872.158.camel@edumazet-glaptop2.roam.corp.google.com> Sender: netdev-owner@vger.kernel.org List-ID: On 09/09/2014 05:41 AM, Eric Dumazet wrote: > On Mon, 2014-09-08 at 22:56 -0700, John Fastabend wrote: >> Signed-off-by: John Fastabend >> --- >> net/sched/cls_flow.c | 145 +++++++++++++++++++++++++++++--------------------- >> 1 file changed, 84 insertions(+), 61 deletions(-) >> >> diff --git a/net/sched/cls_flow.c b/net/sched/cls_flow.c >> index 35be16f..e33560b 100644 >> --- a/net/sched/cls_flow.c >> +++ b/net/sched/cls_flow.c >> @@ -34,12 +34,15 @@ >> >> struct flow_head { >> struct list_head filters; >> + struct rcu_head rcu; >> }; >> >> struct flow_filter { >> struct list_head list; >> + struct rcu_head rcu; > > Please move these 2 new fields at the end of structure, they are only > used at dismantle phase. > > Patch looks fine otherwise, thanks ! > > 2 new fields? The first rcu struct is already at end of structure. I assume you just mean the rcu struct in flow_filter. .John -- John Fastabend Intel Corporation