From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 08/21] xen/arm: Initialize the virtual GIC later Date: Tue, 09 Sep 2014 11:57:27 -0700 Message-ID: <540F4D97.5020202@linaro.org> References: <1406818852-31856-1-git-send-email-julien.grall@linaro.org> <1406818852-31856-9-git-send-email-julien.grall@linaro.org> <1410269732.8217.181.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XRQbd-00066a-GB for xen-devel@lists.xenproject.org; Tue, 09 Sep 2014 18:57:33 +0000 Received: by mail-qc0-f170.google.com with SMTP id r5so18458626qcx.1 for ; Tue, 09 Sep 2014 11:57:30 -0700 (PDT) In-Reply-To: <1410269732.8217.181.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Stefano Stabellini Cc: Ian Jackson , tim@xen.org, stefano.stabellini@citrix.com, Jan Beulich , xen-devel@lists.xenproject.org, Daniel De Graaf List-Id: xen-devel@lists.xenproject.org Hi Ian, On 09/09/14 06:35, Ian Campbell wrote: > On Wed, 2014-08-06 at 16:35 +0100, Stefano Stabellini wrote: > >>> +#if defined(__arm__) || defined(__arch64__) >>> +int xc_domain_configure(xc_interface *xch, uint32_t domid, >>> + uint32_t nr_spis) >> >> Given that we'll likely add new fields to xen_domctl_configuredomain, I >> think it is best if we pass a struct domain_configure to >> xc_domain_configure instead of nr_spis. The struct we pass to >> xc_domain_configure doesn't have to be identical to struct >> xen_domctl_configuredomain, but at the moment it would be. > > In that case you may as well inline the domctl call into > arch_domain_create_pre, which I don't think is a bad idea. It will be hard. Libxl doesn't have access to the facility for create bounce buffer... Regards, -- Julien Grall