From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Date: Tue, 09 Sep 2014 14:37:42 -0500 Message-ID: <540F5706.1050303@tabi.org> References: <20140909183804.GA6944@Asurada> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140909183804.GA6944@Asurada> Sender: linux-kernel-owner@vger.kernel.org To: Nicolin Chen Cc: Shengjiu Wang , Li.Xiubo@freescale.com, lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, mpa@pengutronix.de List-Id: alsa-devel@alsa-project.org On 09/09/2014 01:38 PM, Nicolin Chen wrote: > make sure to have the call for imx only because it seems that > the other platforms do not depend on the clock. Although I doubt anyone will every add support for clocks to PowerPC "side" of this driver, I would prefer to avoid IMX-specific changes. Instead, the code should check if a clock is available. That's why I suggested this change: - if (ssi_private->soc->imx) + if (!IS_ERR(ssi_private->clk)) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from muin.pair.com (muin.pair.com [209.68.1.55]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 309111A06E2 for ; Wed, 10 Sep 2014 05:37:47 +1000 (EST) Message-ID: <540F5706.1050303@tabi.org> Date: Tue, 09 Sep 2014 14:37:42 -0500 From: Timur Tabi MIME-Version: 1.0 To: Nicolin Chen Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module References: <20140909183804.GA6944@Asurada> In-Reply-To: <20140909183804.GA6944@Asurada> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: Shengjiu Wang , alsa-devel@alsa-project.org, tiwai@suse.de, linux-kernel@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, Li.Xiubo@freescale.com, mpa@pengutronix.de, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 09/09/2014 01:38 PM, Nicolin Chen wrote: > make sure to have the call for imx only because it seems that > the other platforms do not depend on the clock. Although I doubt anyone will every add support for clocks to PowerPC "side" of this driver, I would prefer to avoid IMX-specific changes. Instead, the code should check if a clock is available. That's why I suggested this change: - if (ssi_private->soc->imx) + if (!IS_ERR(ssi_private->clk))