From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] xen/arm: Correctly support WARN_ON Date: Tue, 09 Sep 2014 13:25:14 -0700 Message-ID: <540F622A.30603@linaro.org> References: <1407256336-11839-1-git-send-email-julien.grall@linaro.org> <1410181281.3680.3.camel@kazak.uk.xensource.com> <540E0128.8070506@linaro.org> <540E0258.8040702@linaro.org> <1410254340.8217.52.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XRRyY-00021A-Dc for xen-devel@lists.xenproject.org; Tue, 09 Sep 2014 20:25:18 +0000 Received: by mail-qa0-f53.google.com with SMTP id w8so16036507qac.40 for ; Tue, 09 Sep 2014 13:25:15 -0700 (PDT) In-Reply-To: <1410254340.8217.52.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 09/09/14 02:19, Ian Campbell wrote: > On Mon, 2014-09-08 at 12:24 -0700, Julien Grall wrote: >> On 08/09/14 12:19, Julien Grall wrote: >>>> >>>> OOI what is the size increase of the final (stripped) binary with this >>>> patch? >>> >>> I compared the file xen/xen and on both arm32/arm64 the binary is >>> smaller of about 2%. >>> >>> I think this is because previously gcc wasn't merge the string when >>> BUG_ON was used in inline function. >> >> BTW this series won't work correctly because of XSA-102 on ARM64 when >> WARN_ON/BUG_ON/ASSERT is used in startup code. >> This is because the "current" is set to a debug sanity value. >> >> Do you plan to send the series to add support for 32-bit userspace on >> 64-bits kernels for Xen 4.5? > > I must confess I'd forgotten about it. I'll dig it out and brush the > cobwebs off ASAP. Thanks, I saw the series in my inbox. I will give a look today or tomorrow. > In the meantime can the test at the head of do_trap_hypervisor be > extended to DTRT with traps from EL2 (i.e. skip the rest of the > expression)? I plan to do smth like: if ( guest_mode(regs) && ... ) Regards, -- Julien Grall