diff for duplicates of <540F6D34.3060205@suse.de> diff --git a/a/1.txt b/N1/1.txt index 7bbb9b5..cdd0887 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -60,7 +60,8 @@ On 09.09.14 19:07, Madhavan Srinivasan wrote: > +{ > + u32 last_inst; > + -> + if (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> + EMULATE_DONE) { +> + if (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) != +> + EMULATE_DONE) { > + /* > + * Fetch failed, so return to guest and > + * try executing it again. @@ -68,7 +69,7 @@ On 09.09.14 19:07, Madhavan Srinivasan wrote: > + return RESUME_GUEST; > + } > + -> + if (last_inst = KVMPPC_INST_SW_BREAKPOINT) { +> + if (last_inst == KVMPPC_INST_SW_BREAKPOINT) { > + run->exit_reason = KVM_EXIT_DEBUG; > + run->debug.arch.address = kvmppc_get_pc(vcpu); > + return RESUME_HOST; @@ -120,7 +121,7 @@ On 09.09.14 19:07, Madhavan Srinivasan wrote: > +++ b/arch/powerpc/kvm/book3s_pr.c Very nice patch set :). The only thing we're missing now is that Book3S -PR does not allow sw breakpoints to arrive in user mode (MSR.PR = 1), +PR does not allow sw breakpoints to arrive in user mode (MSR.PR == 1), because there we're never going to arrive at kvmppc_emulate_instruction(). But this can come as a follow-up patch. diff --git a/a/content_digest b/N1/content_digest index fb7cbf9..a636486 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,14 +2,14 @@ "ref\01410282456-11287-2-git-send-email-maddy@linux.vnet.ibm.com\0" "From\0Alexander Graf <agraf@suse.de>\0" "Subject\0Re: [PATCH 1/2 v6] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Tue, 09 Sep 2014 21:12:20 +0000\0" + "Date\0Tue, 09 Sep 2014 23:12:20 +0200\0" "To\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>" benh@kernel.crashing.org paulus@samba.org " mpe@ellerman.id.au\0" "Cc\0linuxppc-dev@lists.ozlabs.org" - kvm@vger.kernel.org - " kvm-ppc@vger.kernel.org\0" + kvm-ppc@vger.kernel.org + " kvm@vger.kernel.org\0" "\00:1\0" "b\0" "\n" @@ -74,7 +74,8 @@ "> +{\n" "> +\tu32 last_inst;\n" "> +\n" - "> +\tif (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> +\t\t\t\t\tEMULATE_DONE) {\n" + "> +\tif (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !=\n" + "> +\t\t\t\t\tEMULATE_DONE) {\n" "> +\t\t/*\n" "> +\t\t * Fetch failed, so return to guest and\n" "> +\t\t * try executing it again.\n" @@ -82,7 +83,7 @@ "> +\t\treturn RESUME_GUEST;\n" "> +\t}\n" "> +\n" - "> +\tif (last_inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + "> +\tif (last_inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "> +\t\trun->exit_reason = KVM_EXIT_DEBUG;\n" "> +\t\trun->debug.arch.address = kvmppc_get_pc(vcpu);\n" "> +\t\treturn RESUME_HOST;\n" @@ -134,7 +135,7 @@ "> +++ b/arch/powerpc/kvm/book3s_pr.c\n" "\n" "Very nice patch set :). The only thing we're missing now is that Book3S\n" - "PR does not allow sw breakpoints to arrive in user mode (MSR.PR = 1),\n" + "PR does not allow sw breakpoints to arrive in user mode (MSR.PR == 1),\n" "because there we're never going to arrive at kvmppc_emulate_instruction().\n" "\n" "But this can come as a follow-up patch.\n" @@ -142,4 +143,4 @@ "\n" Alex -20f4bf912e4ea0a73cf25cb3c2fd12b7eda54f96e06c2045de3b150abcd948ac +1d0d4759e813b8b147f0866b0852ac2b5b275359c5a7ab34cf812c863bc29416
diff --git a/a/1.txt b/N2/1.txt index 7bbb9b5..cdd0887 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -60,7 +60,8 @@ On 09.09.14 19:07, Madhavan Srinivasan wrote: > +{ > + u32 last_inst; > + -> + if (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> + EMULATE_DONE) { +> + if (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) != +> + EMULATE_DONE) { > + /* > + * Fetch failed, so return to guest and > + * try executing it again. @@ -68,7 +69,7 @@ On 09.09.14 19:07, Madhavan Srinivasan wrote: > + return RESUME_GUEST; > + } > + -> + if (last_inst = KVMPPC_INST_SW_BREAKPOINT) { +> + if (last_inst == KVMPPC_INST_SW_BREAKPOINT) { > + run->exit_reason = KVM_EXIT_DEBUG; > + run->debug.arch.address = kvmppc_get_pc(vcpu); > + return RESUME_HOST; @@ -120,7 +121,7 @@ On 09.09.14 19:07, Madhavan Srinivasan wrote: > +++ b/arch/powerpc/kvm/book3s_pr.c Very nice patch set :). The only thing we're missing now is that Book3S -PR does not allow sw breakpoints to arrive in user mode (MSR.PR = 1), +PR does not allow sw breakpoints to arrive in user mode (MSR.PR == 1), because there we're never going to arrive at kvmppc_emulate_instruction(). But this can come as a follow-up patch. diff --git a/a/content_digest b/N2/content_digest index fb7cbf9..7cb9371 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -2,7 +2,7 @@ "ref\01410282456-11287-2-git-send-email-maddy@linux.vnet.ibm.com\0" "From\0Alexander Graf <agraf@suse.de>\0" "Subject\0Re: [PATCH 1/2 v6] powerpc/kvm: support to handle sw breakpoint\0" - "Date\0Tue, 09 Sep 2014 21:12:20 +0000\0" + "Date\0Tue, 09 Sep 2014 23:12:20 +0200\0" "To\0Madhavan Srinivasan <maddy@linux.vnet.ibm.com>" benh@kernel.crashing.org paulus@samba.org @@ -74,7 +74,8 @@ "> +{\n" "> +\tu32 last_inst;\n" "> +\n" - "> +\tif (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !> +\t\t\t\t\tEMULATE_DONE) {\n" + "> +\tif (kvmppc_get_last_inst(vcpu, INST_GENERIC, &last_inst) !=\n" + "> +\t\t\t\t\tEMULATE_DONE) {\n" "> +\t\t/*\n" "> +\t\t * Fetch failed, so return to guest and\n" "> +\t\t * try executing it again.\n" @@ -82,7 +83,7 @@ "> +\t\treturn RESUME_GUEST;\n" "> +\t}\n" "> +\n" - "> +\tif (last_inst = KVMPPC_INST_SW_BREAKPOINT) {\n" + "> +\tif (last_inst == KVMPPC_INST_SW_BREAKPOINT) {\n" "> +\t\trun->exit_reason = KVM_EXIT_DEBUG;\n" "> +\t\trun->debug.arch.address = kvmppc_get_pc(vcpu);\n" "> +\t\treturn RESUME_HOST;\n" @@ -134,7 +135,7 @@ "> +++ b/arch/powerpc/kvm/book3s_pr.c\n" "\n" "Very nice patch set :). The only thing we're missing now is that Book3S\n" - "PR does not allow sw breakpoints to arrive in user mode (MSR.PR = 1),\n" + "PR does not allow sw breakpoints to arrive in user mode (MSR.PR == 1),\n" "because there we're never going to arrive at kvmppc_emulate_instruction().\n" "\n" "But this can come as a follow-up patch.\n" @@ -142,4 +143,4 @@ "\n" Alex -20f4bf912e4ea0a73cf25cb3c2fd12b7eda54f96e06c2045de3b150abcd948ac +67b8a38bc52a1c80949f7289ea9aeb2164cc0dc32fd810d743987396dfbaa457
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.