From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRSmU-0002UI-7E for qemu-devel@nongnu.org; Tue, 09 Sep 2014 17:16:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRSmM-0003fU-4R for qemu-devel@nongnu.org; Tue, 09 Sep 2014 17:16:54 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37481 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRSmL-0003fQ-U6 for qemu-devel@nongnu.org; Tue, 09 Sep 2014 17:16:46 -0400 Message-ID: <540F6E3D.7090405@suse.de> Date: Tue, 09 Sep 2014 23:16:45 +0200 From: Alexander Graf MIME-Version: 1.0 References: <20140905135244.104423770@amt.cnet> <20140905135539.188955270@amt.cnet> <20140909151230.GA3106@amt.cnet> In-Reply-To: <20140909151230.GA3106@amt.cnet> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [patch 1/3] kvmclock: Ensure time in migration never goes backward List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti , qemu-devel@nongnu.org Cc: Paolo Bonzini , Andrey Korolyov , =?windows-1252?Q?Marcin_Gibu=C5=3F?= =?windows-1252?Q?a?= Who are you pinging? Alex On 09.09.14 17:12, Marcelo Tosatti wrote: > Ping? > > On Fri, Sep 05, 2014 at 10:52:45AM -0300, Marcelo Tosatti wrote: >> From: Alexander Graf >> >> When we migrate we ask the kernel about its current belief on what the guest >> time would be. However, I've seen cases where the kvmclock guest structure >> indicates a time more recent than the kvm returned time. >> >> To make sure we never go backwards, calculate what the guest would have seen as time at the point of migration and use that value instead of the kernel returned one when it's more recent. >> This bases the view of the kvmclock after migration on the >> same foundation in host as well as guest. >> >> Signed-off-by: Alexander Graf >> Cc: qemu-stable@nongnu.org >> Reviewed-by: Marcelo Tosatti >> Signed-off-by: Paolo Bonzini > >