From: Richard Henderson <rth@twiddle.net>
To: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tcg/README: fix movcond cond argument position
Date: Tue, 09 Sep 2014 16:12:29 -0700 [thread overview]
Message-ID: <540F895D.50302@twiddle.net> (raw)
In-Reply-To: <1410303761-13485-1-git-send-email-jcmvbkbc@gmail.com>
On 09/09/2014 04:02 PM, Max Filippov wrote:
> movcond has its cond argument first, not last. Fix that in
> documentation.
>
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> tcg/README | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcg/README b/tcg/README
> index a550ff1..69f3456 100644
> --- a/tcg/README
> +++ b/tcg/README
> @@ -328,7 +328,7 @@ dest = (t1 cond t2)
>
> Set DEST to 1 if (T1 cond T2) is true, otherwise set to 0.
>
> -* movcond_i32/i64 dest, c1, c2, v1, v2, cond
> +* movcond_i32/i64 cond, dest, c1, c2, v1, v2
No. The README is supposed to be documenting the *opcode* argument ordering,
which really does place cond last.
I agree the situation with the helpers using a different ordering is confusing.
If we were going to change anything to match, it'd have to be the helpers --
the concept of constant opcode arguments coming last is buried quite deep in TCG.
r~
next prev parent reply other threads:[~2014-09-09 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 23:02 [Qemu-devel] [PATCH] tcg/README: fix movcond cond argument position Max Filippov
2014-09-09 23:12 ` Richard Henderson [this message]
2014-09-09 23:18 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F895D.50302@twiddle.net \
--to=rth@twiddle.net \
--cc=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.