From: xerofoify@gmail.com (nick)
To: kernelnewbies@lists.kernelnewbies.org
Subject: Trial Patch
Date: Tue, 09 Sep 2014 22:56:10 -0400 [thread overview]
Message-ID: <540FBDCA.6010408@gmail.com> (raw)
In-Reply-To: <105811.1410317573@turing-police.cc.vt.edu>
On 14-09-09 10:52 PM, Valdis.Kletnieks at vt.edu wrote:
> On Tue, 09 Sep 2014 21:21:18 -0400, nick said:
>> Not going to execute, I wasn't sure if that statement needs to be executed.
>
> skb = dev_alloc_skb(frag_length + 4);
> + if (skb == NULL) {
> + skb_queue_purge(&priv->rtllib->skbwaitQ[TXCMD_QUEUE];
> + break;
> + }
>
> OK. It's official. I see *zero* possibility that you'll ever manage to
> write an acceptable patch. This is *still* wrong.
>
Care to explain.
Nick
next prev parent reply other threads:[~2014-09-10 2:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 3:08 Trial Patch nick
2014-09-09 4:04 ` Valdis.Kletnieks at vt.edu
2014-09-09 12:22 ` nick
2014-09-09 12:42 ` Sudip Mukherjee
2014-09-09 13:24 ` nick
2014-09-09 13:39 ` Sudip Mukherjee
2014-09-09 13:26 ` Valdis.Kletnieks at vt.edu
2014-09-09 13:45 ` Greg Freemyer
2014-09-09 13:54 ` Peter Senna Tschudin
2014-09-09 15:52 ` Nick Krause
2014-09-09 16:40 ` Valdis.Kletnieks at vt.edu
2014-09-09 21:16 ` nick
2014-09-09 21:33 ` Hugo Mills
2014-09-09 22:03 ` Valdis.Kletnieks at vt.edu
2014-09-10 1:21 ` nick
2014-09-10 2:52 ` Valdis.Kletnieks at vt.edu
2014-09-10 2:56 ` nick [this message]
2014-09-10 3:07 ` Valdis.Kletnieks at vt.edu
2014-09-10 3:11 ` nick
2014-09-10 3:53 ` nick
2014-09-10 4:49 ` Valdis.Kletnieks at vt.edu
2014-09-10 11:26 ` nick
2014-09-10 11:36 ` Hugo Mills
2014-09-10 11:38 ` Kristofer Hallin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540FBDCA.6010408@gmail.com \
--to=xerofoify@gmail.com \
--cc=kernelnewbies@lists.kernelnewbies.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.