From: netdev@kapio-technology.com
To: Vladimir Oltean <olteanv@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 2/3] net: dsa: mv88e6xxx: shorten the locked section in mv88e6xxx_g1_atu_prob_irq_thread_fn()
Date: Sat, 07 Jan 2023 10:44:33 +0100 [thread overview]
Message-ID: <540e6577f028c05c8ea39c2a09bce23e@kapio-technology.com> (raw)
In-Reply-To: <20230106163759.42jrkxuyjlg3l3s5@skbuf>
On 2023-01-06 17:37, Vladimir Oltean wrote:
> On Fri, Jan 06, 2023 at 05:05:28PM +0100, Hans J. Schultz wrote:
>> As only the hardware access functions up til and including
>> mv88e6xxx_g1_atu_mac_read() called under the interrupt handler
>> need to take the chip lock, we release the chip lock after this call.
>> The follow up code that handles the violations can run without the
>> chip lock held.
>> In further patches, the violation handler function will even be
>> incompatible with having the chip lock held. This due to an AB/BA
>> ordering inversion with rtnl_lock().
>>
>> Signed-off-by: Hans J. Schultz <netdev@kapio-technology.com>
>> ---
>
> Needs to compile without new warnings patch by patch.
>
> ../drivers/net/dsa/mv88e6xxx/global1_atu.c: In function
> ‘mv88e6xxx_g1_atu_prob_irq_thread_fn’:
> ../drivers/net/dsa/mv88e6xxx/global1_atu.c:460:1: warning: label ‘out’
> defined but not used [-Wunused-label]
> 460 | out:
> | ^~~
> ../drivers/net/dsa/mv88e6xxx/global1_atu.c:460:1: warning: unused label
> 'out'
Can I fix it and resend the same version?
next prev parent reply other threads:[~2023-01-07 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 16:05 [PATCH v3 net-next 0/3] mv88e6xxx: Add MAB offload support Hans J. Schultz
2023-01-06 16:05 ` [PATCH v3 net-next 1/3] net: dsa: mv88e6xxx: change default return of mv88e6xxx_port_bridge_flags Hans J. Schultz
2023-01-06 16:39 ` Vladimir Oltean
2023-01-06 16:05 ` [PATCH v3 net-next 2/3] net: dsa: mv88e6xxx: shorten the locked section in mv88e6xxx_g1_atu_prob_irq_thread_fn() Hans J. Schultz
2023-01-06 16:37 ` Vladimir Oltean
2023-01-07 9:44 ` netdev [this message]
2023-01-07 11:40 ` Vladimir Oltean
2023-01-06 16:05 ` [PATCH v3 net-next 3/3] net: dsa: mv88e6xxx: mac-auth/MAB implementation Hans J. Schultz
2023-01-06 16:41 ` Vladimir Oltean
2023-01-07 10:32 ` netdev
2023-01-07 11:37 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540e6577f028c05c8ea39c2a09bce23e@kapio-technology.com \
--to=netdev@kapio-technology.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.