From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 10 Sep 2014 11:14:46 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:63717 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008655AbaIJJOpEiPRr (ORCPT ); Wed, 10 Sep 2014 11:14:45 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id CCF335EF9E622; Wed, 10 Sep 2014 10:14:34 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 10 Sep 2014 10:14:36 +0100 Received: from [192.168.154.67] (192.168.154.67) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 10 Sep 2014 10:14:36 +0100 Message-ID: <5410167C.2070305@imgtec.com> Date: Wed, 10 Sep 2014 10:14:36 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Ricardo Ribalda Delgado CC: Greg KH , , , LKML , Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions References: <1410263575-26720-1-git-send-email-markos.chandras@imgtec.com> <20140909191736.GA7467@kroah.com> <54100AE5.6050401@imgtec.com> <54100FB0.1000308@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.67] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42493 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote: > Hello Markos > > Sorry for the mess. I have already send a new patch for mips using the > _IO* macros > > Just to put things a bit into context: > > I did made the patch for serial and tested it only in x86. I wrongly > infer that the IOCTLS were defined for all the arches (sorry :S) > > Then when the patch was applied on tty-next the build-bot throw some > errors for xtensa, that I fixed without using the IO_ macros > > Then you came with your patch, > > I realized that this could be wrong for mor arches, so I check the > rest and make patches for them. > > Greg then pointed out that I should use _IO instead of numbers, so I > remade my patches using the _IO macros. I did not want to step into > your patch so I did not prepare a new one for mips > > All the _IO patches (except mips) are now merged into tty-next. > > Hopefully that one also get merged soon :) > > > Thanks for your help and sorry for any disturbance. > > Hi Ricardo, No problem :) Thanks for taking care of that -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:63717 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008655AbaIJJOpEiPRr (ORCPT ); Wed, 10 Sep 2014 11:14:45 +0200 Message-ID: <5410167C.2070305@imgtec.com> Date: Wed, 10 Sep 2014 10:14:36 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions References: <1410263575-26720-1-git-send-email-markos.chandras@imgtec.com> <20140909191736.GA7467@kroah.com> <54100AE5.6050401@imgtec.com> <54100FB0.1000308@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Ricardo Ribalda Delgado Cc: Greg KH , linux-mips@linux-mips.org, linux-next@vger.kernel.org, LKML , linux-serial@vger.kernel.org Message-ID: <20140910091436.ReWzF0auG-mt8XF25tMKVjD8HgbYpVcLqVKHZMiPuLY@z> On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote: > Hello Markos > > Sorry for the mess. I have already send a new patch for mips using the > _IO* macros > > Just to put things a bit into context: > > I did made the patch for serial and tested it only in x86. I wrongly > infer that the IOCTLS were defined for all the arches (sorry :S) > > Then when the patch was applied on tty-next the build-bot throw some > errors for xtensa, that I fixed without using the IO_ macros > > Then you came with your patch, > > I realized that this could be wrong for mor arches, so I check the > rest and make patches for them. > > Greg then pointed out that I should use _IO instead of numbers, so I > remade my patches using the _IO macros. I did not want to step into > your patch so I did not prepare a new one for mips > > All the _IO patches (except mips) are now merged into tty-next. > > Hopefully that one also get merged soon :) > > > Thanks for your help and sorry for any disturbance. > > Hi Ricardo, No problem :) Thanks for taking care of that -- markos