From mboxrd@z Thu Jan 1 00:00:00 1970 From: info@lategoodbye.de (Stefan Wahren) Date: Wed, 10 Sep 2014 19:32:36 +0200 Subject: [PATCH RFC 2/3] ARM: regulator: add Freescale MXS regulator driver In-Reply-To: <20140910151316.GG7960@sirena.org.uk> References: <1410089869-6611-1-git-send-email-info@lategoodbye.de> <1410089869-6611-3-git-send-email-info@lategoodbye.de> <20140909182211.GG3896@leverpostej> <540F523D.4010904@lategoodbye.de> <20140910141853.GA4994@leverpostej> <20140910151316.GG7960@sirena.org.uk> Message-ID: <54108B34.6010701@lategoodbye.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, Am 10.09.2014 17:13, schrieb Mark Brown: > On Wed, Sep 10, 2014 at 03:18:53PM +0100, Mark Rutland wrote: >> On Tue, Sep 09, 2014 at 08:17:17PM +0100, Stefan Wahren wrote: > > Ugh, this looks like it might be a regulator driver but since the > subject line was "ARM: " I deleted it unread - if your changelog looks > different to all the other changelogs in the subsystem it probably needs > changing. sorry about the confusion, i will remove ARM in the next version. Changelog? I didn't send a changelog because it was my first version. Should i resend this version only to you? > >>>>> + sreg = devm_kzalloc(dev, sizeof(*sreg), GFP_KERNEL); >>>>> + if (!sreg) >>>>> + return -ENOMEM; >>>>> + sreg->initdata = initdata; >>>>> + sreg->name = of_get_property(np, "regulator-name", NULL); > >>>> I'm not keen on using of_get_property here. We have no idea if >>>> regulator-name is even a string (it should be, but we have no >>>> guarantee). > >>> Better using of_property_read_string? > >> Yes. That will check the value is NUL-terminated, at least. > > Or just remove the property entirely... without having seen the > bindings if we're specifying the name of the device via the device tree > something seems wrong. > BR Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Wahren Subject: Re: [PATCH RFC 2/3] ARM: regulator: add Freescale MXS regulator driver Date: Wed, 10 Sep 2014 19:32:36 +0200 Message-ID: <54108B34.6010701@lategoodbye.de> References: <1410089869-6611-1-git-send-email-info@lategoodbye.de> <1410089869-6611-3-git-send-email-info@lategoodbye.de> <20140909182211.GG3896@leverpostej> <540F523D.4010904@lategoodbye.de> <20140910141853.GA4994@leverpostej> <20140910151316.GG7960@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140910151316.GG7960@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Mark Rutland , "lgirdwood@gmail.com" , "shawn.guo@linaro.org" , "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "stefan.wahren@i2se.com" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org Hi Mark, Am 10.09.2014 17:13, schrieb Mark Brown: > On Wed, Sep 10, 2014 at 03:18:53PM +0100, Mark Rutland wrote: >> On Tue, Sep 09, 2014 at 08:17:17PM +0100, Stefan Wahren wrote: > > Ugh, this looks like it might be a regulator driver but since the > subject line was "ARM: " I deleted it unread - if your changelog looks > different to all the other changelogs in the subsystem it probably needs > changing. sorry about the confusion, i will remove ARM in the next version. Changelog? I didn't send a changelog because it was my first version. Should i resend this version only to you? > >>>>> + sreg = devm_kzalloc(dev, sizeof(*sreg), GFP_KERNEL); >>>>> + if (!sreg) >>>>> + return -ENOMEM; >>>>> + sreg->initdata = initdata; >>>>> + sreg->name = of_get_property(np, "regulator-name", NULL); > >>>> I'm not keen on using of_get_property here. We have no idea if >>>> regulator-name is even a string (it should be, but we have no >>>> guarantee). > >>> Better using of_property_read_string? > >> Yes. That will check the value is NUL-terminated, at least. > > Or just remove the property entirely... without having seen the > bindings if we're specifying the name of the device via the device tree > something seems wrong. > BR Stefan