All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/4] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable()
Date: Thu, 11 Sep 2014 00:18:48 +0000	[thread overview]
Message-ID: <5410EA68.3080705@renesas.com> (raw)
In-Reply-To: <54102904.6060703@renesas.com>

Hi,

(2014/09/10 22:49), Felipe Balbi wrote:
> On Wed, Sep 10, 2014 at 07:33:40PM +0900, Yoshihiro Shimoda wrote:
>> This patch fixes an issue that the NULL pointer dereference happens
>> when we use g_audio driver. Since the g_audio driver will call
>> usb_ep_disable() in afunc_set_alt() before it calls usb_ep_enable(),
>> the uep->pipe of renesas usbhs driver will be NULL. So, this patch
>> adds a condition to avoid the oops.
>>
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Which commit does this fix ? Do we need a Cc: stable ?
> 

I think we need a Cc: stable in this patch because the previous code causes the oops.

Best regards,
Yoshihiro Shimoda

  parent reply	other threads:[~2014-09-11  0:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10 10:33 [PATCH 1/4] usb: renesas_usbhs: gadget: fix NULL pointer dereference in ep_disable() Yoshihiro Shimoda
2014-09-10 13:49 ` Felipe Balbi
2014-09-10 23:56 ` Kuninori Morimoto
2014-09-11  0:18 ` Yoshihiro Shimoda [this message]
2014-09-11  0:23 ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5410EA68.3080705@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.