From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Thu, 11 Sep 2014 09:27:10 +0800 Message-ID: <5410FA6E.8080708@huawei.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-9-git-send-email-wangyijing@huawei.com> <5409C8C0.8020200@citrix.com> <540E6095.8030409@huawei.com> <54104641.7020007@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54104641.7020007@citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: David Vrabel , Bjorn Helgaas Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Xinwei Hu , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , Benjamin Herrenschmidt , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Chris Metcalf , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Bharat.Bhushan@freescale.com, Tony Luck , Ralf Baechle , iommu@lists.linux-foundation.org, Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: linux-arch.vger.kernel.org On 2014/9/10 20:38, David Vrabel wrote: > On 09/09/14 03:06, Yijing Wang wrote: >> On 2014/9/5 22:29, David Vrabel wrote: >>> On 05/09/14 11:09, Yijing Wang wrote: >>>> Use MSI chip framework instead of arch MSI functions to configure >>>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >>> [...] >>>> --- a/arch/x86/pci/xen.c >>>> +++ b/arch/x86/pci/xen.c >>> [...] >>>> @@ -418,9 +430,9 @@ int __init pci_xen_init(void) >>>> #endif >>>> >>>> #ifdef CONFIG_PCI_MSI >>>> - x86_msi.setup_msi_irqs = xen_setup_msi_irqs; >>>> - x86_msi.teardown_msi_irq = xen_teardown_msi_irq; >>>> - x86_msi.teardown_msi_irqs = xen_teardown_msi_irqs; >>>> + xen_msi_chip.setup_irqs = xen_setup_msi_irqs; >>>> + xen_msi_chip.teardown_irqs = xen_teardown_msi_irqs; >>>> + x86_msi_chip = &xen_msi_chip; >>>> msi_chip.irq_mask = xen_nop_msi_mask; >>>> msi_chip.irq_unmask = xen_nop_msi_mask; >>> >>> Why have these not been changed to set the x86_msi_chip.mask/unmask >>> fields instead? >> >> Hi David, x86_msi_chip here is struct msi_chip data type, used to configure MSI/MSI-X >> irq. msi_chip above is struct irq_chip data type, represent the MSI irq controller. They are >> not the same object. Their name easily confusing people. > > Ok, it all makes sense now. > > Acked-by: David Vrabel Thanks! > > David > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Thu, 11 Sep 2014 01:27:10 +0000 Subject: Re: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq Message-Id: <5410FA6E.8080708@huawei.com> List-Id: References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-9-git-send-email-wangyijing@huawei.com> <5409C8C0.8020200@citrix.com> <540E6095.8030409@huawei.com> <54104641.7020007@citrix.com> In-Reply-To: <54104641.7020007@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Vrabel , Bjorn Helgaas Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Xinwei Hu , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , Benjamin Herrenschmidt , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Chris Metcalf , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Bharat.Bhushan@freescale.com, Tony Luck , Ralf Baechle , iommu@lists.linux-foundation.org, Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On 2014/9/10 20:38, David Vrabel wrote: > On 09/09/14 03:06, Yijing Wang wrote: >> On 2014/9/5 22:29, David Vrabel wrote: >>> On 05/09/14 11:09, Yijing Wang wrote: >>>> Use MSI chip framework instead of arch MSI functions to configure >>>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >>> [...] >>>> --- a/arch/x86/pci/xen.c >>>> +++ b/arch/x86/pci/xen.c >>> [...] >>>> @@ -418,9 +430,9 @@ int __init pci_xen_init(void) >>>> #endif >>>> >>>> #ifdef CONFIG_PCI_MSI >>>> - x86_msi.setup_msi_irqs = xen_setup_msi_irqs; >>>> - x86_msi.teardown_msi_irq = xen_teardown_msi_irq; >>>> - x86_msi.teardown_msi_irqs = xen_teardown_msi_irqs; >>>> + xen_msi_chip.setup_irqs = xen_setup_msi_irqs; >>>> + xen_msi_chip.teardown_irqs = xen_teardown_msi_irqs; >>>> + x86_msi_chip = &xen_msi_chip; >>>> msi_chip.irq_mask = xen_nop_msi_mask; >>>> msi_chip.irq_unmask = xen_nop_msi_mask; >>> >>> Why have these not been changed to set the x86_msi_chip.mask/unmask >>> fields instead? >> >> Hi David, x86_msi_chip here is struct msi_chip data type, used to configure MSI/MSI-X >> irq. msi_chip above is struct irq_chip data type, represent the MSI irq controller. They are >> not the same object. Their name easily confusing people. > > Ok, it all makes sense now. > > Acked-by: David Vrabel Thanks! > > David > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 11 Sep 2014 03:29:43 +0200 (CEST) Received: from szxga01-in.huawei.com ([119.145.14.64]:17139 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27006909AbaIKB3kbMpZs (ORCPT ); Thu, 11 Sep 2014 03:29:40 +0200 Received: from 172.24.2.119 (EHLO szxeml419-hub.china.huawei.com) ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CBM93639; Thu, 11 Sep 2014 09:27:29 +0800 (CST) Received: from [127.0.0.1] (10.177.27.212) by szxeml419-hub.china.huawei.com (10.82.67.158) with Microsoft SMTP Server id 14.3.158.1; Thu, 11 Sep 2014 09:27:14 +0800 Message-ID: <5410FA6E.8080708@huawei.com> Date: Thu, 11 Sep 2014 09:27:10 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: David Vrabel , Bjorn Helgaas CC: , , , Xinwei Hu , , , , Russell King , "Joerg Roedel" , , Sebastian Ott , Benjamin Herrenschmidt , , , Arnd Bergmann , Chris Metcalf , Thomas Gleixner , , , "Tony Luck" , Ralf Baechle , , Wuyun , , "David S. Miller" Subject: Re: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-9-git-send-email-wangyijing@huawei.com> <5409C8C0.8020200@citrix.com> <540E6095.8030409@huawei.com> <54104641.7020007@citrix.com> In-Reply-To: <54104641.7020007@citrix.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 42501 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: wangyijing@huawei.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 2014/9/10 20:38, David Vrabel wrote: > On 09/09/14 03:06, Yijing Wang wrote: >> On 2014/9/5 22:29, David Vrabel wrote: >>> On 05/09/14 11:09, Yijing Wang wrote: >>>> Use MSI chip framework instead of arch MSI functions to configure >>>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >>> [...] >>>> --- a/arch/x86/pci/xen.c >>>> +++ b/arch/x86/pci/xen.c >>> [...] >>>> @@ -418,9 +430,9 @@ int __init pci_xen_init(void) >>>> #endif >>>> >>>> #ifdef CONFIG_PCI_MSI >>>> - x86_msi.setup_msi_irqs = xen_setup_msi_irqs; >>>> - x86_msi.teardown_msi_irq = xen_teardown_msi_irq; >>>> - x86_msi.teardown_msi_irqs = xen_teardown_msi_irqs; >>>> + xen_msi_chip.setup_irqs = xen_setup_msi_irqs; >>>> + xen_msi_chip.teardown_irqs = xen_teardown_msi_irqs; >>>> + x86_msi_chip = &xen_msi_chip; >>>> msi_chip.irq_mask = xen_nop_msi_mask; >>>> msi_chip.irq_unmask = xen_nop_msi_mask; >>> >>> Why have these not been changed to set the x86_msi_chip.mask/unmask >>> fields instead? >> >> Hi David, x86_msi_chip here is struct msi_chip data type, used to configure MSI/MSI-X >> irq. msi_chip above is struct irq_chip data type, represent the MSI irq controller. They are >> not the same object. Their name easily confusing people. > > Ok, it all makes sense now. > > Acked-by: David Vrabel Thanks! > > David > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [119.145.14.64]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 58C7F1A0053 for ; Thu, 11 Sep 2014 11:29:27 +1000 (EST) Message-ID: <5410FA6E.8080708@huawei.com> Date: Thu, 11 Sep 2014 09:27:10 +0800 From: Yijing Wang MIME-Version: 1.0 To: David Vrabel , Bjorn Helgaas Subject: Re: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-9-git-send-email-wangyijing@huawei.com> <5409C8C0.8020200@citrix.com> <540E6095.8030409@huawei.com> <54104641.7020007@citrix.com> In-Reply-To: <54104641.7020007@citrix.com> Content-Type: text/plain; charset="ISO-8859-1" Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Xinwei Hu , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Chris Metcalf , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Bharat.Bhushan@freescale.com, Tony Luck , Ralf Baechle , iommu@lists.linux-foundation.org, Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 2014/9/10 20:38, David Vrabel wrote: > On 09/09/14 03:06, Yijing Wang wrote: >> On 2014/9/5 22:29, David Vrabel wrote: >>> On 05/09/14 11:09, Yijing Wang wrote: >>>> Use MSI chip framework instead of arch MSI functions to configure >>>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >>> [...] >>>> --- a/arch/x86/pci/xen.c >>>> +++ b/arch/x86/pci/xen.c >>> [...] >>>> @@ -418,9 +430,9 @@ int __init pci_xen_init(void) >>>> #endif >>>> >>>> #ifdef CONFIG_PCI_MSI >>>> - x86_msi.setup_msi_irqs = xen_setup_msi_irqs; >>>> - x86_msi.teardown_msi_irq = xen_teardown_msi_irq; >>>> - x86_msi.teardown_msi_irqs = xen_teardown_msi_irqs; >>>> + xen_msi_chip.setup_irqs = xen_setup_msi_irqs; >>>> + xen_msi_chip.teardown_irqs = xen_teardown_msi_irqs; >>>> + x86_msi_chip = &xen_msi_chip; >>>> msi_chip.irq_mask = xen_nop_msi_mask; >>>> msi_chip.irq_unmask = xen_nop_msi_mask; >>> >>> Why have these not been changed to set the x86_msi_chip.mask/unmask >>> fields instead? >> >> Hi David, x86_msi_chip here is struct msi_chip data type, used to configure MSI/MSI-X >> irq. msi_chip above is struct irq_chip data type, represent the MSI irq controller. They are >> not the same object. Their name easily confusing people. > > Ok, it all makes sense now. > > Acked-by: David Vrabel Thanks! > > David > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Thu, 11 Sep 2014 09:27:10 +0800 Subject: [Xen-devel] [PATCH v1 08/21] x86/xen/MSI: Use MSI chip framework to configure MSI/MSI-X irq In-Reply-To: <54104641.7020007@citrix.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-9-git-send-email-wangyijing@huawei.com> <5409C8C0.8020200@citrix.com> <540E6095.8030409@huawei.com> <54104641.7020007@citrix.com> Message-ID: <5410FA6E.8080708@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2014/9/10 20:38, David Vrabel wrote: > On 09/09/14 03:06, Yijing Wang wrote: >> On 2014/9/5 22:29, David Vrabel wrote: >>> On 05/09/14 11:09, Yijing Wang wrote: >>>> Use MSI chip framework instead of arch MSI functions to configure >>>> MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. >>> [...] >>>> --- a/arch/x86/pci/xen.c >>>> +++ b/arch/x86/pci/xen.c >>> [...] >>>> @@ -418,9 +430,9 @@ int __init pci_xen_init(void) >>>> #endif >>>> >>>> #ifdef CONFIG_PCI_MSI >>>> - x86_msi.setup_msi_irqs = xen_setup_msi_irqs; >>>> - x86_msi.teardown_msi_irq = xen_teardown_msi_irq; >>>> - x86_msi.teardown_msi_irqs = xen_teardown_msi_irqs; >>>> + xen_msi_chip.setup_irqs = xen_setup_msi_irqs; >>>> + xen_msi_chip.teardown_irqs = xen_teardown_msi_irqs; >>>> + x86_msi_chip = &xen_msi_chip; >>>> msi_chip.irq_mask = xen_nop_msi_mask; >>>> msi_chip.irq_unmask = xen_nop_msi_mask; >>> >>> Why have these not been changed to set the x86_msi_chip.mask/unmask >>> fields instead? >> >> Hi David, x86_msi_chip here is struct msi_chip data type, used to configure MSI/MSI-X >> irq. msi_chip above is struct irq_chip data type, represent the MSI irq controller. They are >> not the same object. Their name easily confusing people. > > Ok, it all makes sense now. > > Acked-by: David Vrabel Thanks! > > David > > . > -- Thanks! Yijing