From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRujX-0002uq-Mj for qemu-devel@nongnu.org; Wed, 10 Sep 2014 23:07:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRujR-0000eZ-4w for qemu-devel@nongnu.org; Wed, 10 Sep 2014 23:07:43 -0400 Received: from [59.151.112.132] (port=10077 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRujQ-0000cY-Pe for qemu-devel@nongnu.org; Wed, 10 Sep 2014 23:07:37 -0400 Message-ID: <54110EC5.5030603@cn.fujitsu.com> Date: Thu, 11 Sep 2014 10:53:57 +0800 From: Gu Zheng MIME-Version: 1.0 References: <1409735177-17232-1-git-send-email-guz.fnst@cn.fujitsu.com> <20140910161253.718d2b2b@nial.usersys.redhat.com> In-Reply-To: <20140910161253.718d2b2b@nial.usersys.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] cpu/acpi: convert cpu hot plug to hotplug_handler API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, Bharata B Rao , chen.fan.fnst@cn.fujitsu.com, "Jason J. Herne" , afaerber@suse.de Hi Igor, Thanks very much for your review and suggestion. On 09/10/2014 10:12 PM, Igor Mammedov wrote: > On Wed, 3 Sep 2014 17:06:12 +0800 > Gu Zheng wrote: > >> >> Gu Zheng (5): >> acpi/cpu: add cpu hotplug callback function to match hotplug_handler >> API >> acpi:ich9: convert cpu hotplug handle to hotplug_handler API >> acpi:piix4: convert cpu hotplug handle to hotplug_handler API >> pc: add cpu hotplug handler to PC_MACHINE >> cpu/hotplug: remove the left unused cpu hotplug notifier function >> >> hw/acpi/cpu_hotplug.c | 18 ++++++++++++------ >> hw/acpi/ich9.c | 15 +++------------ >> hw/acpi/piix4.c | 16 +++------------- >> hw/i386/pc.c | 26 +++++++++++++++++++++++++- >> include/hw/acpi/cpu_hotplug.h | 6 ++++-- >> include/hw/acpi/ich9.h | 1 - >> qom/cpu.c | 1 - >> 7 files changed, 47 insertions(+), 36 deletions(-) >> > > Looks like right direction that would allow to drop cpu_added_notifiers > which is not able to pass/handle errors and switch to unified hotplug handler > API which allows to pass errors and would allow to cancel device_add in case of > error. It seems the key value we can gain from above change, I'll follow your suggestion. > > PS: > Gu Zheng, > > Please grep for qemu_register_cpu_added_notifier(), you've missed to convert > rtc usage of CPU notifier. Thanks for your reminder. > > I'd prefer this to go in before you device_add/add cpu series. OK, I'll work on this series first. Best regards, Gu > . >