All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Ask help about pre_init_apic_IRQ0()
Date: Thu, 11 Sep 2014 16:44:54 +0800	[thread overview]
Message-ID: <54116106.5090904@linux.intel.com> (raw)

Hi Thomas,

When converting IOAPIC to hierarchy irqdomain, I ran into trouble when
dealing with pre_init_apic_IRQ0(). Currently pre_init_apic_IRQ0() is
only used by intel-mid platform and is called before initializing of
IOAPIC irqdomains. That really causes headache when converting to
hierarchy irqdomain. So could we delay
	io_apic_setup_irq_pin(0, 0, &attr);
        irq_set_chip_and_handler_name(0, &ioapic_chip, handle_edge_irq,
                                      "edge");
to the point of "check_timer()"?

I have no MID hardware at handle so can't experiment with it. Could
you please refer someone for help?

/* Enable IOAPIC early just for system timer */
void __init pre_init_apic_IRQ0(void)
{
        struct io_apic_irq_attr attr = { 0, 0, 0, 0 };

        printk(KERN_INFO "Early APIC setup for system timer0\n");
#ifndef CONFIG_SMP
        physid_set_mask_of_physid(boot_cpu_physical_apicid,
                                         &phys_cpu_present_map);
#endif
        setup_local_APIC();

        io_apic_setup_irq_pin(0, 0, &attr);
        irq_set_chip_and_handler_name(0, &ioapic_chip, handle_edge_irq,
                                      "edge");
}

Regards!
Gerry

             reply	other threads:[~2014-09-11  8:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  8:44 Jiang Liu [this message]
2014-09-11  8:53 ` Ask help about pre_init_apic_IRQ0() Mika Westerberg
2014-09-11  9:08   ` Andy Shevchenko
2014-09-11 23:17     ` David Cohen
2014-09-11 12:58 ` Thomas Gleixner
2014-09-11 14:03   ` Andy Shevchenko
2014-09-11 14:35     ` Thomas Gleixner
2014-09-11 15:15       ` Andy Shevchenko
2014-09-11 21:59         ` Thomas Gleixner
2014-09-12  8:19           ` Andy Shevchenko
2014-09-12  8:26             ` Thomas Gleixner
2014-09-12  9:25               ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54116106.5090904@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.