Re: Inconsistent error state transition error frames

[Andri Yngvason <andri.yngvason@marel.com>]

On mið 10.sep 2014 19:08, Oliver Hartkopp wrote:
>
>> I'm not sure... we also need to set the value. Therefore I would
>> vote for:
>>
>>   frame->data[CAN_ERR_TXERR_BYTE];
>>
>> It does make the code more readable.
> Unfortunately CAN_ERR_TXERR_BYTE is pretty long and I have no good idea
> how to make it shorter. CAN_ERR_TXERR_IDX is probably more handy.
>
> E.g.
>
> 	frame->data[CAN_ERR_CTRL_IDX] |= CAN_ERR_CRTL_RX_OVERFLOW;
>
> I would vote for something like this too.
>
> Should I send a patch for this approach?
Don't most people have auto-completion in their editors nowadays? 
Anyway, I'd been thinking about suggesting 'INDEX' rather than 'BYTE' 
because it really is a more descriptive name, so I'm happy with 'IDX'. 
'BYTE' can mean other things while 'IDX' is pretty clear.

Andri