From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: [PATCH 3/4] drm: Simplify return value of drm_get_last_vbltimestamp Date: Thu, 11 Sep 2014 13:28:23 +0200 Message-ID: <54118757.7030506@gmail.com> References: <1410363371-11282-1-git-send-email-daniel.vetter@ffwll.ch> <1410363371-11282-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lb0-f170.google.com (mail-lb0-f170.google.com [209.85.217.170]) by gabe.freedesktop.org (Postfix) with ESMTP id 8096C6E56B for ; Thu, 11 Sep 2014 04:28:27 -0700 (PDT) Received: by mail-lb0-f170.google.com with SMTP id c11so757637lbj.29 for ; Thu, 11 Sep 2014 04:28:26 -0700 (PDT) In-Reply-To: <1410363371-11282-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gMDkvMTAvMjAxNCAwNTozNiBQTSwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBJbW8gdTMyIGhp bnRzIGF0IGEgcmVnaXN0ZXIgdmFsdWUsIGJ1dCBpbiByZWFsaXR5IGFsbCBjYWxsZXJzIG9ubHkK PiBjYXJlIHdoZXRoZXIgdGhlIHNhbXBsZWQgdGltZXN0YW1wIGlzIHByZWNpc2Ugb3Igbm90LiBT byBnaXZlIHRoZW0KPiBqdXN0IGEgYm9vbC4KPgo+IEFsc28gbW92ZSB0aGUgZGVjbGFyYXRpb24g b3V0IG9mIGRybVAuaCwgaXQncyBvbmx5IHVzZWQgaW4gZHJtX2lycS5jLgoKQWxsIGdvb2QuIE1h eWJlIHRoZW4gYWxzbyByZW1vdmUKCkVYUE9SVF9TWU1CT0woZHJtX2dldF9sYXN0X3ZibHRpbWVz dGFtcCk7CgppbiB0aGlzIHBhdGNoIGlmIHRoZSBtZXRob2QgaXMgbm93IHN0YXRpYyB0byBkcm1f aXJxLmMgPyBVcCB0byB5b3UuCgpGb3IgYWxsIDQgcGF0Y2hlcy4uLgoKUmV2aWV3ZWQtYnk6IE1h cmlvIEtsZWluZXIgPG1hcmlvLmtsZWluZXIuZGVAZ21haWwuY29tPgoKLW1hcmlvCgoKCj4gQ2M6 IE1hcmlvIEtsZWluZXIgPG1hcmlvLmtsZWluZXIuZGVAZ21haWwuY29tPgo+IENjOiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2RybV9pcnEuYyB8IDI0ICsrKysrKysrKysrKysrKy0tLS0tLS0tLQo+ICAgaW5j bHVkZS9kcm0vZHJtUC5oICAgICAgICB8ICAyIC0tCj4gICAyIGZpbGVzIGNoYW5nZWQsIDE1IGlu c2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1faXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4gaW5kZXggOTIyNzIx ZWFkMjlhLi5iMTZmMGJjZWY5NTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9p cnEuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPiBAQCAtNzAsNiArNzAsMTAg QEAgbW9kdWxlX3BhcmFtX25hbWVkKHZibGFua29mZmRlbGF5LCBkcm1fdmJsYW5rX29mZmRlbGF5 LCBpbnQsIDA2MDApOwo+ICAgbW9kdWxlX3BhcmFtX25hbWVkKHRpbWVzdGFtcF9wcmVjaXNpb25f dXNlYywgZHJtX3RpbWVzdGFtcF9wcmVjaXNpb24sIGludCwgMDYwMCk7Cj4gICBtb2R1bGVfcGFy YW1fbmFtZWQodGltZXN0YW1wX21vbm90b25pYywgZHJtX3RpbWVzdGFtcF9tb25vdG9uaWMsIGlu dCwgMDYwMCk7Cj4gICAKPiArc3RhdGljIGJvb2wKPiArZHJtX2dldF9sYXN0X3ZibHRpbWVzdGFt cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgY3J0YywKPiArCQkJICBzdHJ1Y3QgdGltZXZh bCAqdHZibGFuaywgdW5zaWduZWQgZmxhZ3MpOwo+ICsKPiAgIC8qKgo+ICAgICogZHJtX3VwZGF0 ZV92YmxhbmtfY291bnQgLSB1cGRhdGUgdGhlIG1hc3RlciB2YmxhbmsgY291bnRlcgo+ICAgICog QGRldjogRFJNIGRldmljZQo+IEBAIC04OSw3ICs5Myw4IEBAIG1vZHVsZV9wYXJhbV9uYW1lZCh0 aW1lc3RhbXBfbW9ub3RvbmljLCBkcm1fdGltZXN0YW1wX21vbm90b25pYywgaW50LCAwNjAwKTsK PiAgIHN0YXRpYyB2b2lkIGRybV91cGRhdGVfdmJsYW5rX2NvdW50KHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIGludCBjcnRjKQo+ICAgewo+ICAgCXN0cnVjdCBkcm1fdmJsYW5rX2NydGMgKnZibGFu ayA9ICZkZXYtPnZibGFua1tjcnRjXTsKPiAtCXUzMiBjdXJfdmJsYW5rLCBkaWZmLCB0c2xvdCwg cmM7Cj4gKwl1MzIgY3VyX3ZibGFuaywgZGlmZiwgdHNsb3Q7Cj4gKwlib29sIHJjOwo+ICAgCXN0 cnVjdCB0aW1ldmFsIHRfdmJsYW5rOwo+ICAgCj4gICAJLyoKPiBAQCAtMTQ3LDcgKzE1Miw3IEBA IHN0YXRpYyB2b2lkIHZibGFua19kaXNhYmxlX2FuZF9zYXZlKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIGludCBjcnRjKQo+ICAgCXVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4gICAJdTMyIHZibGNv dW50Owo+ICAgCXM2NCBkaWZmX25zOwo+IC0JaW50IHZibHJjOwo+ICsJYm9vbCB2YmxyYzsKPiAg IAlzdHJ1Y3QgdGltZXZhbCB0dmJsYW5rOwo+ICAgCWludCBjb3VudCA9IERSTV9USU1FU1RBTVBf TUFYUkVUUklFUzsKPiAgIAo+IEBAIC0xNzEsNyArMTc2LDcgQEAgc3RhdGljIHZvaWQgdmJsYW5r X2Rpc2FibGVfYW5kX3NhdmUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IGNydGMpCj4gICAJ ICogdmJsYW5rIGludGVycnVwdCBpcyBkaXNhYmxlZC4KPiAgIAkgKi8KPiAgIAlpZiAoIXZibGFu ay0+ZW5hYmxlZCAmJgo+IC0JICAgIGRybV9nZXRfbGFzdF92Ymx0aW1lc3RhbXAoZGV2LCBjcnRj LCAmdHZibGFuaywgMCkgPiAwKSB7Cj4gKwkgICAgZHJtX2dldF9sYXN0X3ZibHRpbWVzdGFtcChk ZXYsIGNydGMsICZ0dmJsYW5rLCAwKSkgewo+ICAgCQlkcm1fdXBkYXRlX3ZibGFua19jb3VudChk ZXYsIGNydGMpOwo+ICAgCQlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXYtPnZibGFua190aW1l X2xvY2ssIGlycWZsYWdzKTsKPiAgIAkJcmV0dXJuOwo+IEBAIC0yMTksNyArMjI0LDcgQEAgc3Rh dGljIHZvaWQgdmJsYW5rX2Rpc2FibGVfYW5kX3NhdmUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwg aW50IGNydGMpCj4gICAJICogYXZhaWxhYmxlLiBJbiB0aGF0IGNhc2Ugd2UgY2FuJ3QgYWNjb3Vu dCBmb3IgdGhpcyBhbmQganVzdAo+ICAgCSAqIGhvcGUgZm9yIHRoZSBiZXN0Lgo+ICAgCSAqLwo+ IC0JaWYgKCh2YmxyYyA+IDApICYmIChhYnM2NChkaWZmX25zKSA+IDEwMDAwMDApKSB7Cj4gKwlp ZiAodmJscmMgJiYgKGFiczY0KGRpZmZfbnMpID4gMTAwMDAwMCkpIHsKPiAgIAkJLyogU3RvcmUg bmV3IHRpbWVzdGFtcCBpbiByaW5nYnVmZmVyLiAqLwo+ICAgCQl2Ymxhbmt0aW1lc3RhbXAoZGV2 LCBjcnRjLCB2Ymxjb3VudCArIDEpID0gdHZibGFuazsKPiAgIAo+IEBAIC03ODYsMTAgKzc5MSwx MSBAQCBzdGF0aWMgc3RydWN0IHRpbWV2YWwgZ2V0X2RybV90aW1lc3RhbXAodm9pZCkKPiAgICAq IGNhbGwsIGkuZS4sIGl0IGlzbid0IHZlcnkgcHJlY2lzZWx5IGxvY2tlZCB0byB0aGUgdHJ1ZSB2 YmxhbmsuCj4gICAgKgo+ICAgICogUmV0dXJuczoKPiAtICogTm9uLXplcm8gaWYgdGltZXN0YW1w IGlzIGNvbnNpZGVyZWQgdG8gYmUgdmVyeSBwcmVjaXNlLCB6ZXJvIG90aGVyd2lzZS4KPiArICog VHJ1ZSBpZiB0aW1lc3RhbXAgaXMgY29uc2lkZXJlZCB0byBiZSB2ZXJ5IHByZWNpc2UsIGZhbHNl IG90aGVyd2lzZS4KPiAgICAqLwo+IC11MzIgZHJtX2dldF9sYXN0X3ZibHRpbWVzdGFtcChzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgY3J0YywKPiAtCQkJICAgICAgc3RydWN0IHRpbWV2YWwg KnR2YmxhbmssIHVuc2lnbmVkIGZsYWdzKQo+ICtzdGF0aWMgYm9vbAo+ICtkcm1fZ2V0X2xhc3Rf dmJsdGltZXN0YW1wKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBjcnRjLAo+ICsJCQkgIHN0 cnVjdCB0aW1ldmFsICp0dmJsYW5rLCB1bnNpZ25lZCBmbGFncykKPiAgIHsKPiAgIAlpbnQgcmV0 Owo+ICAgCj4gQEAgLTgwMSw3ICs4MDcsNyBAQCB1MzIgZHJtX2dldF9sYXN0X3ZibHRpbWVzdGFt cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBpbnQgY3J0YywKPiAgIAkJcmV0ID0gZGV2LT5kcml2 ZXItPmdldF92YmxhbmtfdGltZXN0YW1wKGRldiwgY3J0YywgJm1heF9lcnJvciwKPiAgIAkJCQkJ CQl0dmJsYW5rLCBmbGFncyk7Cj4gICAJCWlmIChyZXQgPiAwKQo+IC0JCQlyZXR1cm4gKHUzMikg cmV0Owo+ICsJCQlyZXR1cm4gdHJ1ZTsKPiAgIAl9Cj4gICAKPiAgIAkvKiBHUFUgaGlnaCBwcmVj aXNpb24gdGltZXN0YW1wIHF1ZXJ5IHVuc3VwcG9ydGVkIG9yIGZhaWxlZC4KPiBAQCAtODA5LDcg KzgxNSw3IEBAIHUzMiBkcm1fZ2V0X2xhc3RfdmJsdGltZXN0YW1wKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIGludCBjcnRjLAo+ICAgCSAqLwo+ICAgCSp0dmJsYW5rID0gZ2V0X2RybV90aW1lc3Rh bXAoKTsKPiAgIAo+IC0JcmV0dXJuIDA7Cj4gKwlyZXR1cm4gZmFsc2U7Cj4gICB9Cj4gICBFWFBP UlRfU1lNQk9MKGRybV9nZXRfbGFzdF92Ymx0aW1lc3RhbXApOwo+ICAgCj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvZHJtL2RybVAuaCBiL2luY2x1ZGUvZHJtL2RybVAuaAo+IGluZGV4IGFkOTUyYjA4 NzExZS4uMmNjYjBlNzE1NTY5IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybVAuaAo+ICsr KyBiL2luY2x1ZGUvZHJtL2RybVAuaAo+IEBAIC0xMDA0LDggKzEwMDQsNiBAQCBleHRlcm4gdm9p ZCBkcm1fY3J0Y192Ymxhbmtfb2ZmKHN0cnVjdCBkcm1fY3J0YyAqY3J0Yyk7Cj4gICBleHRlcm4g dm9pZCBkcm1fY3J0Y192Ymxhbmtfb24oc3RydWN0IGRybV9jcnRjICpjcnRjKTsKPiAgIGV4dGVy biB2b2lkIGRybV92YmxhbmtfY2xlYW51cChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsKPiAgIAo+ IC1leHRlcm4gdTMyIGRybV9nZXRfbGFzdF92Ymx0aW1lc3RhbXAoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgaW50IGNydGMsCj4gLQkJCQkgICAgIHN0cnVjdCB0aW1ldmFsICp0dmJsYW5rLCB1bnNp Z25lZCBmbGFncyk7Cj4gICBleHRlcm4gaW50IGRybV9jYWxjX3ZibHRpbWVzdGFtcF9mcm9tX3Nj YW5vdXRwb3Moc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgIAkJCQkJCSBpbnQgY3J0YywgaW50 ICptYXhfZXJyb3IsCj4gICAJCQkJCQkgc3RydWN0IHRpbWV2YWwgKnZibGFua190aW1lLAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK