From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table Date: Thu, 11 Sep 2014 13:41:50 +0200 Message-ID: <54118A7E.4090902@collabora.co.uk> References: <1410249158-18192-1-git-send-email-sjoerd.simons@collabora.co.uk> <540ED495.20609@collabora.co.uk> <20140910092832.GM30307@lee--X1> <1410422429.2857.16.camel@collabora.co.uk> <54115F6E.3010007@collabora.co.uk> <5411693A.3050300@itdev.co.uk> <20140911110829.GA5149@katana> <54118687.8040802@collabora.co.uk> <20140911113548.GB5149@katana> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140911113548.GB5149@katana> Sender: linux-samsung-soc-owner@vger.kernel.org To: Wolfram Sang Cc: Nick Dyer , Sjoerd Simons , Lee Jones , Dmitry Torokhov , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, "Bowens, Alan" List-Id: linux-input@vger.kernel.org Hello Wolfram, On 09/11/2014 01:35 PM, Wolfram Sang wrote: > >> > This is a workaround. It would make sense, however, to add it because we >> > want to support i2c_board_info structures. >> > >> >> I think it really depends if an IP block can be used on non-DT platforms >> (which I think is true for this trackpad) but if a driver is for an IP block >> that can only be used on a DT-only platform (e.g: a PMIC that is controlled >> over I2C and is only compatible with a DT-only SoC) then I don't think we need >> to support the i2c_board_info structure and can get rid of the I2C ID table on >> these drivers once Lee series land. > > That is exactly what I meant. It should be only added if there is a > reason other than "workaround". If you say, it doesn't make sense on > non-DT, then it should not be added. > Sorry for explaining myself badly. I just tried to say that this is a decision that has to be made on a per-driver basis but I don't really know if makes sense or not in this case since I don't know if this device is (or could be) shipped on non-DT platforms. Nick is in a much better position to answer that question. Best regards, Javier