From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: Re: [PATCH 21/29] tools/libxl: Allow adding larger
 amounts of prefixdata to datacopier
Date: Thu, 11 Sep 2014 13:17:08 +0100
Message-ID: <541192C4.1080604@citrix.com>
References: <1410369067-1330-1-git-send-email-andrew.cooper3@citrix.com>	
	<1410369067-1330-22-git-send-email-andrew.cooper3@citrix.com>
	<1410436915.25388.3.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410436915.25388.3.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 09/11/2014 01:01 PM, Ian Campbell wrote:
> On Wed, 2014-09-10 at 18:10 +0100, Andrew Cooper wrote:
>> From: Ross Lagerwall <ross.lagerwall@citrix.com>
>>
>> Previously, adding more than 1000 bytes of data would cause a segfault.
>
> Segfault is a symptom, not a cause, why does it happen?

struct libxl__datacopier_buf contains a fixed size 1000 byte statically 
allocated buffer so adding > 1000 bytes of data would cause it to 
overrun the buffer and overwrite other memory.

Regards
-- 
Ross Lagerwall