From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 26/29] tools/libxl: Implement libxl__domain_restore() for v2 streams Date: Thu, 11 Sep 2014 14:01:56 +0100 Message-ID: <54119D44.5010706@citrix.com> References: <1410369067-1330-1-git-send-email-andrew.cooper3@citrix.com> <1410369067-1330-27-git-send-email-andrew.cooper3@citrix.com> <1410438932.25388.10.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410438932.25388.10.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Ross Lagerwall , Ian Jackson , Xen-devel List-Id: xen-devel@lists.xenproject.org On 11/09/14 13:35, Ian Campbell wrote: > On Wed, 2014-09-10 at 18:11 +0100, Andrew Cooper wrote: >> TODO: >> * Integrate with the json series > How much will that invalidate the patch wrt my reviewing it now? Hopefully not much, but it does complicate the use of d_config. Perhaps we can start with d_config being unconditional, and the json series can make it optional in the case a blob can be found in the stream. > >> Signed-off-by: Ross Lagerwall >> Signed-off-by: Andrew Cooper >> --- >> tools/libxl/libxl_create.c | 310 ++++++++++++++++++++++++++++++++++++++++-- > Would it be possible to move most/all of the restore code into a new > file? If it doesn't involve exposing too many currently static bits then > that might be a good thing to do. > > > Most code should be self contained. libxl_domain_{save,restore}.c sound like a good idea. ~Andrew