From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 20/29] tools/libxl: Update datacopier to
 support sending data only
Date: Thu, 11 Sep 2014 14:03:05 +0100
Message-ID: <54119D89.1090100@citrix.com>
References: <1410369067-1330-1-git-send-email-andrew.cooper3@citrix.com>		
	<1410369067-1330-21-git-send-email-andrew.cooper3@citrix.com>	
	<1410436609.25388.1.camel@kazak.uk.xensource.com>	
	<54118EF9.8010607@citrix.com>
	<1410439140.25388.12.camel@kazak.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1410439140.25388.12.camel@kazak.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Wen Congyang <wency@cn.fujitsu.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/09/14 13:39, Ian Campbell wrote:
> On Thu, 2014-09-11 at 13:00 +0100, Andrew Cooper wrote:
>> On 11/09/14 12:56, Ian Campbell wrote:
>>> On Wed, 2014-09-10 at 18:10 +0100, Andrew Cooper wrote:
>>>> From: Wen Congyang <wency@cn.fujitsu.com>
>>>>
>>>> datacopier is to read some data and write it out. If we
>>>> have some data to send it over network, we cannot use
>>>> datacopier. Update it to support this case.
>>> I'm afraid I'm not sure what this changelog is saying. If we have data
>>> to send over the network then why can't we use datacopier? How does
>>> making this conditional on readfd's validity help that case?
>> datacopier was originally strictly copying data from infd to outfd,
>> until EOF.
>>
>> These patches around here in the series extend datacopier to include
>> "please write this local buffer to outfd", "please read $N bytes from
>> infd to this local buffer", and "please copy exactly $N bytes from infd
>> to outfd", all as asynchronous operations.
> Thanks, that all needs to be clearly explained in the commit log.
>
> I'm going to leave it to Ian to decide if this is an acceptable
> repurposing of the datacopier infrastructure.
>
> Ian.
>

Ian explicitly requested modification of datacopier in preference to
adding similar infrastructure with a different name, when I talked to
him in person.

~Andrew