From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS42f-0003WB-NV for qemu-devel@nongnu.org; Thu, 11 Sep 2014 09:04:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XS42Y-0001n1-2j for qemu-devel@nongnu.org; Thu, 11 Sep 2014 09:04:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39013) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XS42X-0001mv-S6 for qemu-devel@nongnu.org; Thu, 11 Sep 2014 09:03:58 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8BD3uuP024307 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 11 Sep 2014 09:03:56 -0400 Message-ID: <54119DBB.3080007@redhat.com> Date: Thu, 11 Sep 2014 07:03:55 -0600 From: Eric Blake MIME-Version: 1.0 References: <1410439779-20402-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1410439779-20402-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OSbW4bIIcUdSIFuNBeu33Tdn0rJoEhRbe" Subject: Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OSbW4bIIcUdSIFuNBeu33Tdn0rJoEhRbe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/11/2014 06:49 AM, Stefan Hajnoczi wrote: > Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use= > with operation blocker") broke the error path because it consumed > local_err instead of propagating it. >=20 > The caller has no way to know that the function failed. This caused > virtio-blk to start "successfully" even though there was a fatal > dataplane error. >=20 > --- > hw/block/dataplane/virtio-blk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OSbW4bIIcUdSIFuNBeu33Tdn0rJoEhRbe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUEZ27AAoJEKeha0olJ0NqTkoH+wavsBaGTeeVWs6BfE1z2Ifz 8pT+Kjcv9/dliuAZyIufs6XPUeTKYGlAc5+dtV55ptECGjp881ZDXzhbJJGFgGdf /yAIA7/3uu+I8/2lMAZLQMvJnTImrm7rQjoprizW8+dSpwrBGyFWkL5NGMUkNXon jfwc7mX96ayzcyMI+kG/D/mVD9XF6Ll19YwR0CUh1F0Y7PYSP5Km5U3KzkfB4QJL 2abeXje4BM2UY4lGb1Ns51WgIQ+CW/xERVaL5t77oby5IgvcNfkND/phpxqCehlm 7HZB4SUwIBnOgUqPMqxgDsRM1undnfg6qEHW73UDj5uAJ7pLNDIUOkJvsh6c7Fk= =hAah -----END PGP SIGNATURE----- --OSbW4bIIcUdSIFuNBeu33Tdn0rJoEhRbe--