From: Chris Mason <clm@fb.com>
To: <rongqing.li@windriver.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: fix a overflowing boundary writing in csum_tree_block
Date: Thu, 11 Sep 2014 10:02:16 -0400 [thread overview]
Message-ID: <5411AB68.7020506@fb.com> (raw)
In-Reply-To: <1410254376-6357-1-git-send-email-rongqing.li@windriver.com>
On 09/09/2014 05:19 AM, rongqing.li@windriver.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
>
> It is impossible that csum_size is larger than sizeof(long), but the codes
> still add the handler for this condition, like allocate new memory, for
> extension. If it becomes true someday, copying csum_size size memory to local
> 32bit variable found and val will overflow these two variables.
>
> Fix it by returning the max 4 byte checksum.
Thanks for the patch. I'd rather not silently truncate the copy down
though. How about a one time check at mount to make sure the value in
the super is reasonable?
-chris
next prev parent reply other threads:[~2014-09-11 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 9:19 [PATCH] btrfs: fix a overflowing boundary writing in csum_tree_block rongqing.li
2014-09-11 14:02 ` Chris Mason [this message]
2014-09-12 1:50 ` Li RongQing
2014-09-29 15:55 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411AB68.7020506@fb.com \
--to=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rongqing.li@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.