From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH v3 2/4] kvmtool: ARM64: Add target type potenza for aarch64 Date: Thu, 11 Sep 2014 17:07:39 +0100 Message-ID: <5411C8CB.9020308@arm.com> References: <1410164258-27469-1-git-send-email-anup.patel@linaro.org> <1410164258-27469-3-git-send-email-anup.patel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org" , "patches@apm.com" , Will Deacon , Marc Zyngier , "penberg@kernel.org" , "christoffer.dall@linaro.org" , "pranavkumar@linaro.org" To: Anup Patel , "kvmarm@lists.cs.columbia.edu" Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:55144 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756876AbaIKQIK (ORCPT ); Thu, 11 Sep 2014 12:08:10 -0400 In-Reply-To: <1410164258-27469-3-git-send-email-anup.patel@linaro.org> Sender: kvm-owner@vger.kernel.org List-ID: Anup, On 08/09/14 09:17, Anup Patel wrote: > The VCPU target type KVM_ARM_TARGET_XGENE_POTENZA is available > in latest Linux-3.16-rcX or higher hence register aarch64 target > type for it. > > This patch enables us to run KVMTOOL on X-Gene Potenza host. Why do you need this still if the previous patch got rid of the need for naming each and every CPU in kvmtool? Do you care about kernels older than 3.12? I wouldn't bother so much since you'd need a much newer kvmtool anyway. Can you consider dropping this patch then? I'd rather avoid adding CPUs to this list needlessly from now on. Regards, Andre. > > Signed-off-by: Pranavkumar Sawargaonkar > Signed-off-by: Anup Patel > --- > tools/kvm/arm/aarch64/arm-cpu.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/tools/kvm/arm/aarch64/arm-cpu.c b/tools/kvm/arm/aarch64/arm-cpu.c > index ce5ea2f..ce526e3 100644 > --- a/tools/kvm/arm/aarch64/arm-cpu.c > +++ b/tools/kvm/arm/aarch64/arm-cpu.c > @@ -41,10 +41,17 @@ static struct kvm_arm_target target_cortex_a57 = { > .init = arm_cpu__vcpu_init, > }; > > +static struct kvm_arm_target target_potenza = { > + .id = KVM_ARM_TARGET_XGENE_POTENZA, > + .compatible = "arm,arm-v8", > + .init = arm_cpu__vcpu_init, > +}; > + > static int arm_cpu__core_init(struct kvm *kvm) > { > return (kvm_cpu__register_kvm_arm_target(&target_aem_v8) || > kvm_cpu__register_kvm_arm_target(&target_foundation_v8) || > - kvm_cpu__register_kvm_arm_target(&target_cortex_a57)); > + kvm_cpu__register_kvm_arm_target(&target_cortex_a57) || > + kvm_cpu__register_kvm_arm_target(&target_potenza)); > } > core_init(arm_cpu__core_init); >