From: Alex Elder <elder@ieee.org>
To: Ilya Dryomov <ilya.dryomov@inktank.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] rbd: do not return -ERANGE on auth failure
Date: Thu, 11 Sep 2014 11:43:44 -0500 [thread overview]
Message-ID: <5411D140.6040807@ieee.org> (raw)
In-Reply-To: <CALFYKtAyR_hNMa92UL7v3bkHx6gCQ-O1G=98Ls08Cq8Ly_imbg@mail.gmail.com>
On 09/11/2014 11:27 AM, Ilya Dryomov wrote:
>> I should have asked this before. Why is a permission error
>> > leading to ceph_extract_encoded_string() finding a short
>> > buffer? I didn't take the time to trace the error path
>> > you're talking about here all the way back.
> rbd_obj_method_sync() returns -EPERM, which when compared with size_t
> from sizeof() ends up a big positive. ceph_extract_encoded_string() is
> then called and the safe decode macro kicks in..
I somehow got lost along the way and thought rbd_obj_method_sync()
was returning -ERANGE. The problem starts because rbd_obj_method_sync()
returns an error other than -ENOENT, and that led me astray I think.
Sorry for the confusion.
-Alex
next prev parent reply other threads:[~2014-09-11 16:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 15:10 [PATCH] rbd: do not return -ERANGE on auth failure Ilya Dryomov
2014-09-11 15:23 ` Alex Elder
2014-09-11 16:17 ` Ilya Dryomov
2014-09-11 16:24 ` Alex Elder
2014-09-11 16:27 ` Ilya Dryomov
2014-09-11 16:43 ` Alex Elder [this message]
2014-09-11 16:46 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411D140.6040807@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ilya.dryomov@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.