From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494AbaIKSly (ORCPT ); Thu, 11 Sep 2014 14:41:54 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:56135 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbaIKSlw (ORCPT ); Thu, 11 Sep 2014 14:41:52 -0400 Message-ID: <5411ECE9.8050600@gmail.com> Date: Thu, 11 Sep 2014 11:41:45 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Mike Looijmans , netdev@vger.kernel.org CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031 References: <1410443140-2833-1-git-send-email-mike.looijmans@topic.nl> In-Reply-To: <1410443140-2833-1-git-send-email-mike.looijmans@topic.nl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/11/2014 06:45 AM, Mike Looijmans wrote: > Our KSZ9031 appears to suffer from the same hardware bug as described > for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577, > you have to unplug the cable and plug it back to get it to work. > > Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this. Can you resend this patch specifying the commit subject in parenthesis like this: commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577 ("net/phy: micrel: Disable asymmetric pause for KSZ9021") since this is a bugfix, it should probably be targeting the 'net' tree, rather than the 'net-next' tree, though the patch applies to both cleanly. Other than that: Acked-by: Florian Fainelli > > Signed-off-by: Mike Looijmans > --- > drivers/net/phy/micrel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index 5a8993b..a932a35 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -425,8 +425,7 @@ static struct phy_driver ksphy_driver[] = { > .phy_id = PHY_ID_KSZ9031, > .phy_id_mask = 0x00fffff0, > .name = "Micrel KSZ9031 Gigabit PHY", > - .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause > - | SUPPORTED_Asym_Pause), > + .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause), > .flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT, > .config_init = kszphy_config_init, > .config_aneg = genphy_config_aneg, >