From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] SPI: mxc_spi: remove second reset from ECSPI config handler
Date: Fri, 12 Sep 2014 10:50:58 +0200 [thread overview]
Message-ID: <5412B3F2.9050800@denx.de> (raw)
In-Reply-To: <1409561218-30707-2-git-send-email-list-09_u-boot@tqsc.de>
Hi Markus,
On 01/09/2014 10:46, Markus Niebel wrote:
> From: Markus Niebel <Markus.Niebel@tq-group.com>
>
> the second reset prevents other registers to be written.
> This will prevent to have the correct signal levels for
> SCLK before writing to the config reg in spi_xchg_single.
>
> Tested with GPIO based chipselect and SPI_MODE_3 on i.MX6S
>
> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
> ---
> drivers/spi/mxc_spi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
> index 2d5f385..6a05d15 100644
> --- a/drivers/spi/mxc_spi.c
> +++ b/drivers/spi/mxc_spi.c
> @@ -163,9 +163,6 @@ static s32 spi_cfg_mxc(struct mxc_spi_slave *mxcs, unsigned int cs,
> reg_ctrl = (reg_ctrl & ~MXC_CSPICTRL_POSTDIV(0x0F)) |
> MXC_CSPICTRL_POSTDIV(post_div);
>
> - /* We need to disable SPI before changing registers */
> - reg_ctrl &= ~MXC_CSPICTRL_EN;
> -
> if (mode & SPI_CS_HIGH)
> ss_pol = 1;
>
>
Acked-by: Stefano Babic <sbabic@denx.de>
Jagannadha, this series is currently assigned to me in patchwork. Should
I merge into u-boot-imx or do you prefer to merge the two patches into
u-boot-spi ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2014-09-12 8:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 8:46 [U-Boot] [PATCH 0/2] SPI: mxc_spi: slave initialisation fixes Markus Niebel
2014-09-01 8:46 ` [U-Boot] [PATCH 1/2] SPI: mxc_spi: remove second reset from ECSPI config handler Markus Niebel
2014-09-12 8:50 ` Stefano Babic [this message]
2014-09-12 9:10 ` Jagan Teki
2014-09-01 8:46 ` [U-Boot] [PATCH 2/2] SPI: mxc_spi: delay initialisation until claim bus Markus Niebel
2014-09-24 18:23 ` Jagan Teki
2014-09-24 18:42 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412B3F2.9050800@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.