From: David Vrabel <david.vrabel@citrix.com>
To: Julien Grall <julien.grall@linaro.org>, <xen-devel@lists.xenproject.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
David Vrabel <david.vrabel@citrix.com>,
Jiri Slaby <jslaby@suse.cz>
Subject: Re: [Xen-devel] [PATCH] xen/hvc: Fix warning compilation when CONFIG_HVC_XEN_FRONTEND is not enabled
Date: Fri, 12 Sep 2014 10:39:29 +0100 [thread overview]
Message-ID: <5412BF51.5070402@citrix.com> (raw)
In-Reply-To: <1410479459-20353-1-git-send-email-julien.grall@linaro.org>
On 12/09/14 00:50, Julien Grall wrote:
> The below warning appears when the hvc xen driver is compiled without
> CONFIG_HVC_XEN_FRONTEND not enabled:
>
> drivers/tty/hvc/hvc_xen.c:333:12: warning: ‘xen_console_remove’ defined but not
> used [-Wunused-function]
> static int xen_console_remove(struct xencons_info *info)
> ^
>
> Move the #ifdef CONFIG_HVC_XEN_FRONTEND earlier to only compile
> xen_console_remove, xen_cons_free, xen_cons_disconnect_backend when it's
> necessary.
Reviewed-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2014-09-12 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 23:50 [PATCH] xen/hvc: Fix warning compilation when CONFIG_HVC_XEN_FRONTEND is not enabled Julien Grall
2014-09-12 9:39 ` David Vrabel [this message]
2014-09-12 9:39 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412BF51.5070402@citrix.com \
--to=david.vrabel@citrix.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=julien.grall@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.