All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@intel.com>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	srinivas.pandruvada@linux.intel.com
Subject: Re: [PATCH] iio:kxcjk-1013: Add support for SMO8500 device
Date: Fri, 12 Sep 2014 15:24:26 +0300	[thread overview]
Message-ID: <5412E5FA.2070707@intel.com> (raw)
In-Reply-To: <1410459518.32328.24.camel@hadess.net>


On 09/11/2014 09:18 PM, Bastien Nocera wrote:
> On Tue, 2014-09-09 at 21:53 +0300, Daniel Baluta wrote:
>> Hi Bastien,
>>
>> On Tue, Sep 9, 2014 at 8:19 PM, Bastien Nocera <hadess@hadess.net> wrote:
>>> The Onda v975w tablet contains an accelerometer that's advertised over
>>> ACPI as SMO8500. This device is however a KXCJ9 accelerometer as
>>> can be seen in the Windows driver's INF file.
>>> ---
>>>
>>> I tested the patch, and it works correctly in my testing. However,
>>> there's no GPIO pin for the "data ready" interrupt, and this throws an
>>> error that looks fatal in the logs (could this be downgraded?), and
>>> the name of the device doesn't match the hid-sensor-hub ones, making it
>>> hard for user-space to discover them.
>>> (https://github.com/hadess/iio-sensor-proxy is my attempt at something
>>>   that integrates with user-space and the IIO sensors)
>>>
How did you test it? There is no GpioInt associated with your device in 
the the .dsl file.
What kind of error do you see in the logs?
>> How does your ACPI .dsl file looks like?
>>
>>> It will also conflict with Daniel's patch here:
>>> http://www.spinics.net/lists/linux-iio/msg14438.html
>> It shouldn't. The patch is already in togreg branch of Jonathan's tree
>> [1]. Anyhow,
>> it will conflict with this one [2].
> Do you want me to rebase the patch on a particular tree? Do you need any
> particular changes done in my commit message or patch to get this
> merged?
>
I would suggest you wait until Jonathan merges this patch [1] in togreg 
branch [2].
Then rebase your patch on togreg branch and get feedback from Jonathan 
and Srinivas.

thanks,
Daniel.

[1] http://www.spinics.net/lists/linux-iio/msg14655.html
[2] https://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/log/?h=togreg

  reply	other threads:[~2014-09-12 12:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09 17:19 [PATCH] iio:kxcjk-1013: Add support for SMO8500 device Bastien Nocera
2014-09-09 18:53 ` Daniel Baluta
2014-09-09 18:58   ` Bastien Nocera
2014-09-11 18:18   ` Bastien Nocera
2014-09-12 12:24     ` Daniel Baluta [this message]
2014-09-12 12:24       ` Bastien Nocera
2014-09-14 14:11         ` Jonathan Cameron
2014-09-25  8:49           ` Bastien Nocera
2014-09-25 12:47             ` Jonathan Cameron
2014-09-14 14:05 ` Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2014-11-03 23:07 Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5412E5FA.2070707@intel.com \
    --to=daniel.baluta@intel.com \
    --cc=hadess@hadess.net \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.