From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id E677965E2B for ; Fri, 12 Sep 2014 13:01:12 +0000 (UTC) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail.windriver.com (8.14.9/8.14.5) with ESMTP id s8CD1Ds4012262 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Fri, 12 Sep 2014 06:01:13 -0700 (PDT) Received: from [128.224.162.181] (128.224.162.181) by ALA-HCB.corp.ad.wrs.com (147.11.189.41) with Microsoft SMTP Server id 14.3.174.1; Fri, 12 Sep 2014 06:01:12 -0700 Message-ID: <5412EE97.4040902@windriver.com> Date: Fri, 12 Sep 2014 21:01:11 +0800 From: Robert Yang User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: References: <63e89adc5ffc2c1e30a4b2a41ca0988e95158554.1410279874.git.liezhi.yang@windriver.com> <54108595.6080809@topic.nl> <5411BFA4.4050206@windriver.com> <5412EDC0.8090000@topic.nl> In-Reply-To: <5412EDC0.8090000@topic.nl> Subject: Re: [PATCH 02/14] autofs: add bash to RDEPENDS_autofs X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Sep 2014 13:01:14 -0000 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit On 09/12/2014 08:57 PM, Mike wrote: > On 09/11/2014 05:28 PM, Robert Yang wrote: >> >> >> On 09/11/2014 01:08 AM, Mike Looijmans wrote: >>> Wouldn't it be a LOT more constructive to fix the bashism. I fail to >>> see the >>> virtue in adding 2MB of "bash" to an embedded system just for a text echo >>> statement that no-one will actually read unless they hook up a serial >>> console to >>> their TV set or so. >> >> The problem is that there are more bashism, here is the full list: >> >> possible bashism in autofs/etc/init.d/autofs line 39 ('function' is >> useless): >> function start() { >> possible bashism in autofs/etc/init.d/autofs line 52 ([^] should be [!]): >> elif ([ -f /proc/modules ] && lsmod) | grep -q autofs[^4] >> possible bashism in autofs/etc/init.d/autofs line 88 ('function' is >> useless): >> function stop() { >> possible bashism in autofs/etc/init.d/autofs line 89 ($"foo" should be >> eval_gettext "foo"): >> echo -n $"Stopping $prog: " >> possible bashism in autofs/etc/init.d/autofs line 92 (should be >word >> 2>&1): >> killall -TERM $prog >& /dev/null >> possible bashism in autofs/etc/init.d/autofs line 105 ('function' is >> useless): >> function restart() { >> possible bashism in autofs/etc/init.d/autofs line 113 ('function' is >> useless): >> function reload() { >> possible bashism in autofs/etc/init.d/autofs line 116 ($"foo" should be >> eval_gettext "foo"): >> echo $"$prog not running" >> possible bashism in autofs/etc/init.d/autofs line 120 ($"foo" should be >> eval_gettext "foo"): >> echo $"Reloading maps" >> possible bashism in autofs/etc/init.d/autofs line 150 ($"foo" should be >> eval_gettext "foo"): >> echo $"Usage: $0 >> {start|forcestart|stop|restart|forcerestart|reload}" >> >> // Robert >> > > I put the following in a bbappend to work around the bashism, this was enough to > make the scripts work just fine with busybox's shell: Good, thanks, I will update it with your signed-off. // Robert > > > # Remove bash scripting from init script (meaning, remove "function" > # from each shell function) > do_configure_prepend () { > for bashfile in redhat/autofs.init.in samples/rc.autofs.in > do > sed -i 's.#!/bin/bash.#!/bin/sh.' $bashfile > sed -i 's/^function //g' $bashfile > done > } > > > I wanted to point to the commit on sourceforge, but the site is unresponsive at > the moment. > >>> >>> >>> On 9-9-2014 18:27, Robert Yang wrote: >>>> Bashism: >>>> [snip] >>>> possible bashism in autofs/etc/init.d/autofs line 116 ($"foo" should be >>>> eval_gettext "foo"): >>>> echo $"$prog not running" >>>> possible bashism in autofs/etc/init.d/autofs line 120 ($"foo" should be >>>> eval_gettext "foo"): >>>> echo $"Reloading maps" >>>> possible bashism in autofs/etc/init.d/autofs line 150 ($"foo" should be >>>> eval_gettext "foo"): >>>> echo $"Usage: $0 >>>> {start|forcestart|stop|restart|forcerestart|reload}" >>>> [snip] >>>> >>>> Signed-off-by: Robert Yang >>>> --- >>>> .../recipes-daemons/autofs/autofs_5.1.0.bb | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb >>>> b/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb >>>> index aab2187..06ee77b 100644 >>>> --- a/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb >>>> +++ b/meta-networking/recipes-daemons/autofs/autofs_5.1.0.bb >>>> @@ -4,6 +4,7 @@ LICENSE = "GPL-2.0" >>>> LIC_FILES_CHKSUM = >>>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3" >>>> >>>> DEPENDS += "libtirpc flex-native bison-native" >>>> +RDEPENDS_${PN} += "bash" >>>> >>>> inherit autotools-brokensep systemd >>>> >>>> >>> >>> > >