From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Lavnikevich Subject: Re: [PATCH 1/5] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 Date: Fri, 12 Sep 2014 18:55:46 +0300 Message-ID: <54131782.2000204@sam-solutions.net> References: <1410356809-26179-1-git-send-email-d.lavnikevich@sam-solutions.com> <1410356809-26179-2-git-send-email-d.lavnikevich@sam-solutions.com> <1410425238.4011.18.camel@paszta.hi.pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410425238.4011.18.camel-+qGW7pzALmz7o/J7KWpOmN53zsg1cpMQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Philipp Zabel , Dmitry Lavnikevich Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-l3A5Bk7waGM@public.gmane.org, timur-N01EOCouUvQ@public.gmane.org, nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Li.Xiubo-KZfg59tc24xl57MIdRCFDg@public.gmane.org, grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org List-Id: alsa-devel@alsa-project.org On 11/09/14 11:47, Philipp Zabel wrote: > Am Mittwoch, den 10.09.2014, 16:46 +0300 schrieb Dmitry Lavnikevich: >> Since pins and frequency are specific to module (pfla02), not base board >> (pbab02), it is better to be initialized in corresponding dts file. >> >> Signed-off-by: Dmitry Lavnikevich > I have seen boards use the GPIO_3/6 pads instead of EIM_D17/D18 for > I2C3, but the EIM_D17/D18 are indeed documented as "I2C1" pins at the > pfla02 connector level. > > regards > Philipp > Yes, that is why I thought about moving it into pfla02. But apart from it, i2c2grp i2c3grp nodes was wrongly placed under iomuxc node while it should be grouped inside of it, like in imx6q-phytec-pfla02 to which it was moved with this patch. Because of this specified i2c wasn't working correctly and caused messages: imx6q-pinctrl 20e0000.iomuxc: no groups defined in /soc/aips-bus@02000000/iomuxc@020e0000/i2c2grp imx6q-pinctrl 20e0000.iomuxc: no groups defined in /soc/aips-bus@02000000/iomuxc@020e0000/i2c3grp imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c2grp imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c3grp Added this into commit message with new patchset. Best regards, Lavnikevich Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: d.lavnikevich@sam-solutions.net (Dmitry Lavnikevich) Date: Fri, 12 Sep 2014 18:55:46 +0300 Subject: [PATCH 1/5] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 In-Reply-To: <1410425238.4011.18.camel@paszta.hi.pengutronix.de> References: <1410356809-26179-1-git-send-email-d.lavnikevich@sam-solutions.com> <1410356809-26179-2-git-send-email-d.lavnikevich@sam-solutions.com> <1410425238.4011.18.camel@paszta.hi.pengutronix.de> Message-ID: <54131782.2000204@sam-solutions.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/09/14 11:47, Philipp Zabel wrote: > Am Mittwoch, den 10.09.2014, 16:46 +0300 schrieb Dmitry Lavnikevich: >> Since pins and frequency are specific to module (pfla02), not base board >> (pbab02), it is better to be initialized in corresponding dts file. >> >> Signed-off-by: Dmitry Lavnikevich > I have seen boards use the GPIO_3/6 pads instead of EIM_D17/D18 for > I2C3, but the EIM_D17/D18 are indeed documented as "I2C1" pins at the > pfla02 connector level. > > regards > Philipp > Yes, that is why I thought about moving it into pfla02. But apart from it, i2c2grp i2c3grp nodes was wrongly placed under iomuxc node while it should be grouped inside of it, like in imx6q-phytec-pfla02 to which it was moved with this patch. Because of this specified i2c wasn't working correctly and caused messages: imx6q-pinctrl 20e0000.iomuxc: no groups defined in /soc/aips-bus at 02000000/iomuxc at 020e0000/i2c2grp imx6q-pinctrl 20e0000.iomuxc: no groups defined in /soc/aips-bus at 02000000/iomuxc at 020e0000/i2c3grp imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c2grp imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c3grp Added this into commit message with new patchset. Best regards, Lavnikevich Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752368AbaILP4O (ORCPT ); Fri, 12 Sep 2014 11:56:14 -0400 Received: from s250.sam-solutions.net ([217.21.49.219]:58218 "EHLO s250.sam-solutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751682AbaILP4M (ORCPT ); Fri, 12 Sep 2014 11:56:12 -0400 Message-ID: <54131782.2000204@sam-solutions.net> Date: Fri, 12 Sep 2014 18:55:46 +0300 From: Dmitry Lavnikevich Organization: SaM Solutions User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Philipp Zabel , Dmitry Lavnikevich CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH 1/5] ARM: dts: pbab01: move i2c pins and frequency configuration into pfla02 References: <1410356809-26179-1-git-send-email-d.lavnikevich@sam-solutions.com> <1410356809-26179-2-git-send-email-d.lavnikevich@sam-solutions.com> <1410425238.4011.18.camel@paszta.hi.pengutronix.de> In-Reply-To: <1410425238.4011.18.camel@paszta.hi.pengutronix.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.117.165] X-ClientProxiedBy: S326.sam-solutions.net (217.21.35.11) To S326.sam-solutions.net (217.21.35.11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/09/14 11:47, Philipp Zabel wrote: > Am Mittwoch, den 10.09.2014, 16:46 +0300 schrieb Dmitry Lavnikevich: >> Since pins and frequency are specific to module (pfla02), not base board >> (pbab02), it is better to be initialized in corresponding dts file. >> >> Signed-off-by: Dmitry Lavnikevich > I have seen boards use the GPIO_3/6 pads instead of EIM_D17/D18 for > I2C3, but the EIM_D17/D18 are indeed documented as "I2C1" pins at the > pfla02 connector level. > > regards > Philipp > Yes, that is why I thought about moving it into pfla02. But apart from it, i2c2grp i2c3grp nodes was wrongly placed under iomuxc node while it should be grouped inside of it, like in imx6q-phytec-pfla02 to which it was moved with this patch. Because of this specified i2c wasn't working correctly and caused messages: imx6q-pinctrl 20e0000.iomuxc: no groups defined in /soc/aips-bus@02000000/iomuxc@020e0000/i2c2grp imx6q-pinctrl 20e0000.iomuxc: no groups defined in /soc/aips-bus@02000000/iomuxc@020e0000/i2c3grp imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c2grp imx6q-pinctrl 20e0000.iomuxc: unable to find group for node i2c3grp Added this into commit message with new patchset. Best regards, Lavnikevich Dmitry