From: Ben Greear <greearb@candelatech.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [RFC PATCH 3/3] ath10k: add cal_data debugfs file
Date: Fri, 12 Sep 2014 09:17:55 -0700 [thread overview]
Message-ID: <54131CB3.3070104@candelatech.com> (raw)
In-Reply-To: <874mwdyux5.fsf@kamboji.qca.qualcomm.com>
On 09/12/2014 03:50 AM, Kalle Valo wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> On 11 September 2014 22:31, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>>> Provide calibration data used by the firmware to user space via a debugfs file.
>>> This makes it easier to debug calibration related problems.
>>>
>>> Example:
>>>
>>> sudo cp /sys/kernel/debug/ieee80211/phy0/ath10k/cal_data 1.cal
>>
>> How about having a generic r/w access to target memory via debugfs?
>> Userspace would deal with the extraction of the cal data.
>
> Yeah, Yanbo is working on that kind of generic interface.
>
>> Or do you want to make it easier for the user to provide the cal data
>> without any extra tools (and that sending entire unprocessed target
>> memory dump may introduce some privacy concerns)?
>
> This (to make it easier) is exactly my motivation here. In some of the
> problems, especially once we add support to get calibration data from
> host instead of just OTP, it's important to get easily access to the
> calibration data. User only needs to do a simple cp operation and send
> the file to us for further investigation.
>
> Of course we could use the generic target memory interface for this, but
> it's just more complicated for an unexperienced user and that's why I
> think we should have this interface. But to be honest I'm not 100% sure
> yet so other comments are more than welcome.
Different firmware may place this at different locations, so I definitely
like a well-defined interface to grab the requested data instead of having to
try to grab it out of a full ram dump.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2014-09-12 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 20:31 [RFC PATCH 0/3] ath10k: export calibration data to user space Kalle Valo
2014-09-11 20:31 ` [RFC PATCH 1/3] ath10k: ignore diagnose pipes in ath10k_pci_ce_recv_data()/_send_done() Kalle Valo
2014-09-12 7:53 ` Michal Kazior
2014-09-12 8:01 ` Kalle Valo
2014-09-11 20:31 ` [RFC PATCH 2/3] ath10k: add diag_read() to hif ops Kalle Valo
2014-09-12 9:57 ` Michal Kazior
2014-09-12 10:03 ` Kalle Valo
2014-09-11 20:31 ` [RFC PATCH 3/3] ath10k: add cal_data debugfs file Kalle Valo
2014-09-11 20:53 ` Kalle Valo
2014-09-11 22:45 ` Ben Greear
2014-09-12 11:25 ` Kalle Valo
2014-09-12 10:11 ` Michal Kazior
2014-09-12 10:50 ` Kalle Valo
2014-09-12 16:17 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54131CB3.3070104@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@qca.qualcomm.com \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.