From: "Álvaro Neira Ayuso" <alvaroneay@gmail.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH] payload: generate expression using big endian byteorder
Date: Fri, 12 Sep 2014 19:04:59 +0200 [thread overview]
Message-ID: <541327BB.40609@gmail.com> (raw)
In-Reply-To: <20140912130012.GJ26224@acer.localdomain>
IHello Patrick
El 12/09/14 15:00, Patrick McHardy escribió:
> On Fri, Sep 12, 2014 at 02:47:03PM +0200, Alvaro Neira Ayuso wrote:
>> If we try to add a rule like:
>>
>> nft add rule filter input udp length {55-9999}
>>
>> nft shows:
>>
>> BUG: invalid byte order conversion 0 => 2
>> nft: src/evaluate.c:153: byteorder_conversion_op: Assertion `0' failed.
>>
>> Some of the existing payload fields rely on BYTEORDER_INVALID. Therefore, if we
>> try to convert it in evaluation step, we hit this bug.
>>
>> The packets from the Internet are always in big endian. Therefore, we can create
>> all the payload expressions using big endian byteorder.
>
> No, that's not true for MAC addresses and also a bad assumption to make
> in general.
You are right. I forgot that case. I supposed wrong.
>
> What's wrong with the patch you sent previously? I think this is the
> correct way to fix it.
Nothing. I'm going to follow the previous way for fixing this bug.
Thanks Patrick.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-09-12 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 12:47 [nft PATCH] payload: generate expression using big endian byteorder Alvaro Neira Ayuso
2014-09-12 13:00 ` Patrick McHardy
2014-09-12 17:04 ` Álvaro Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541327BB.40609@gmail.com \
--to=alvaroneay@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.