From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v2 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads Date: Sat, 13 Sep 2014 10:10:23 +0200 Message-ID: <5413FBEF.3020101@redhat.com> References: <1410512912-11609-1-git-send-email-hdegoede@redhat.com> <1410512912-11609-4-git-send-email-hdegoede@redhat.com> <20140913002629.GA12622@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31047 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbaIMIK2 (ORCPT ); Sat, 13 Sep 2014 04:10:28 -0400 In-Reply-To: <20140913002629.GA12622@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: Peter Hutterer , Benjamin Tissoires , linux-input@vger.kernel.org Hi, On 09/13/2014 02:26 AM, Dmitry Torokhov wrote: > Hi Hans, > > On Fri, Sep 12, 2014 at 11:08:32AM +0200, Hans de Goede wrote: >> +/* Always check for focaltech, this is safe as it uses pnp-id matching */ >> + if (psmouse_do_detect(focaltech_detect, psmouse, set_properties) == 0) { >> + if (!set_properties || focaltech_init(psmouse) == 0) { >> + /* Not supported yet, use bare protocol */ >> + psmouse_max_proto = PSMOUSE_PS2; > > I do not believe we need to muck with psmouse_max_proto here, so I'll > drop it and apply. Oh, but we do need to set psmouse_max_proto, otherwise this won't work, as I already tried to explain in the review of v1 (but clearly failed to do so). psmouse_initialize() checks psmouse_max_proto, and if it is not set to PSMOUSE_PS2 does things which upsets these touchpads. Regards, Hans