From: Chen Gang <gang.chen.5i5j@gmail.com>
To: konrad.wilk@oracle.com, boris.ostrovsky@oracle.com,
David Vrabel <david.vrabel@citrix.com>,
stefano.stabellini@eu.citrix.com, mukesh.rathor@oracle.com
Cc: xen-devel@lists.xenproject.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr'
Date: Sun, 14 Sep 2014 18:49:33 +0800 [thread overview]
Message-ID: <541572BD.3040101@gmail.com> (raw)
In-Reply-To: <54157282.40402@gmail.com>
When failure occurs, 'node' is already set to NULL, and it is enough
for next checking (which will return in time), so need not set 'addr'.
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/xen/xenbus/xenbus_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/xen/xenbus/xenbus_client.c b/drivers/xen/xenbus/xenbus_client.c
index 439c9dc..277e74d 100644
--- a/drivers/xen/xenbus/xenbus_client.c
+++ b/drivers/xen/xenbus/xenbus_client.c
@@ -636,7 +636,7 @@ static int xenbus_unmap_ring_vfree_hvm(struct xenbus_device *dev, void *vaddr)
goto found;
}
}
- node = addr = NULL;
+ node = NULL;
found:
spin_unlock(&xenbus_valloc_lock);
--
1.9.3
next prev parent reply other threads:[~2014-09-14 10:49 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 10:48 [PATCH 0/4] drivers/xen/xenbus/xenbus_client.c: Several improvements for it Chen Gang
2014-09-14 10:49 ` Chen Gang [this message]
2014-09-14 10:54 ` [PATCH 1/4] drivers/xen/xenbus/xenbus_client.c: Remove redundancy asignment to 'addr' Chen Gang
2014-09-14 10:54 ` Chen Gang
2014-09-15 15:41 ` [Xen-devel] " David Vrabel
2014-09-15 22:49 ` Chen Gang
2014-09-15 22:49 ` Chen Gang
2014-09-15 15:41 ` David Vrabel
2014-09-14 10:49 ` Chen Gang
2014-09-14 10:50 ` [PATCH 2/4] drivers/xen/xenbus/xenbus_client.c: Correct the comments for xenbus_grant_ring() Chen Gang
2014-09-14 10:50 ` Chen Gang
2014-09-15 15:27 ` David Vrabel
2014-09-15 15:27 ` [Xen-devel] " David Vrabel
2014-09-15 22:53 ` Chen Gang
2014-09-15 22:53 ` Chen Gang
2014-09-14 10:51 ` [PATCH 3/4] drivers/xen/xenbus/xenbus_client.c: Remove BUG_ON() when error string truncated Chen Gang
2014-09-14 10:51 ` Chen Gang
2014-09-14 10:52 ` [PATCH 4/4] drivers/xen/xenbus/xenbus_client.c: Improve the failure processing for __xenbus_switch_state() Chen Gang
2014-09-14 10:52 ` Chen Gang
2014-09-15 14:39 ` David Vrabel
2014-09-15 22:57 ` Chen Gang
2014-09-15 22:57 ` Chen Gang
2014-09-15 14:39 ` David Vrabel
2014-09-16 1:07 ` Boris Ostrovsky
2014-09-16 1:39 ` Chen Gang
2014-09-16 1:39 ` Chen Gang
2014-09-16 1:07 ` Boris Ostrovsky
2014-09-15 15:31 ` [Xen-devel] [PATCH 0/4] drivers/xen/xenbus/xenbus_client.c: Several improvements for it David Vrabel
2014-09-15 22:50 ` Chen Gang
2014-09-15 22:50 ` Chen Gang
2014-09-15 15:31 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541572BD.3040101@gmail.com \
--to=gang.chen.5i5j@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.